New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[vcpkg] pass -disableMetrics to bootstrap on git bash #11299
[vcpkg] pass -disableMetrics to bootstrap on git bash #11299
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@linquize, does this fix work for you?
@strega-nil, I test it, it looks doesn't work, can you confirm? you can see the 'vcpkgmetricsuploader.exe' generated and move to vcpkg\scripts. MINGW64 /f/vcpkg/11299/vcpkg (bootstrap-disable-metrics) pch.cpp Building vcpkg.exe... done. |
I tried '.\bootstrap-vcpkg.bat -disableMetrics' on master with latest source. you can see vcpkgmetricsuploader disabled. PS F:\vcpkg\src> .\bootstrap-vcpkg.bat -disableMetrics Building vcpkg.exe ... pch.cpp Building vcpkg.exe... done. |
@PhoebeHui that actually changed recently; we used to build vcpkgmetricsuploader always, not just when metrics were enabled (at least aiui). If you rebase this onto master, you'll see that vcpkgmetricsuploader no longer gets built. |
in git bash, we call back into bootstrap-vcpkg.bat, but we don't pass -disableMetrics through. This commit corrects this
1de36c7
to
e00ed7d
Compare
48c4707
to
e00ed7d
Compare
in git bash, we call back into bootstrap-vcpkg.bat,
but we don't pass -disableMetrics through.
This commit corrects this.
Fixes #11274