Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nlohmann-json] Update to 3.9.0 #12601

Merged
merged 4 commits into from Aug 5, 2020
Merged

[nlohmann-json] Update to 3.9.0 #12601

merged 4 commits into from Aug 5, 2020

Conversation

thewhiteninja
Copy link
Contributor

Update nlohmann-json to 3.9.0

@strega-nil
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
@PhoebeHui
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui PhoebeHui changed the title Update nlohmann-json to 3.9.0 [nlohmann-json] Update to 3.9.0 Jul 28, 2020
@PhoebeHui PhoebeHui self-assigned this Jul 28, 2020
@PhoebeHui PhoebeHui added the category:port-update The issue is with a library, which is requesting update new revision label Jul 28, 2020
@PhoebeHui
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui PhoebeHui closed this Jul 29, 2020
@PhoebeHui PhoebeHui reopened this Jul 29, 2020
@thewhiteninja
Copy link
Contributor Author

Does anyone know why the checks keep failling/hanging ?

@strega-nil
Copy link
Contributor

@thewhiteninja it was an issue with msys2; we fixed it but we have to rerun all of the PR tests.

@strega-nil strega-nil closed this Jul 30, 2020
@strega-nil strega-nil reopened this Jul 30, 2020
@strega-nil
Copy link
Contributor

It is way way way too easy to hit "close and comment" when you mean to hit "comment". I'm so sorry -.-

@thewhiteninja
Copy link
Contributor Author

/azp run

@azure-pipelines
Copy link

Commenter does not have sufficient privileges for PR 12601 in repo microsoft/vcpkg

@PhoebeHui
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the PR!

@strega-nil
Copy link
Contributor

@thewhiteninja it looks like we should update xeus as well; I think that we need to either patch it to use /permissive-, or #include <ciso646>

@thewhiteninja
Copy link
Contributor Author

thewhiteninja commented Aug 5, 2020

Is it ok if I add a commit to this PR to add ciso646 to xeus ?
If yes, the patch is ready :)

@strega-nil
Copy link
Contributor

@thewhiteninja yeah

@strega-nil strega-nil merged commit 953b957 into microsoft:master Aug 5, 2020
hellozee pushed a commit to hellozee/vcpkg that referenced this pull request Sep 11, 2020
* Update to 3.9.0

* Update ports/nlohmann-json/CONTROL

Co-authored-by: nicole mazzuca <mazzucan@outlook.com>

* add a patch to fix the build and nlohmann-json checks.

Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-update The issue is with a library, which is requesting update new revision
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants