New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nlohmann-json] Update to 3.9.0 #12601
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Does anyone know why the checks keep failling/hanging ? |
@thewhiteninja it was an issue with msys2; we fixed it but we have to rerun all of the PR tests. |
It is way way way too easy to hit "close and comment" when you mean to hit "comment". I'm so sorry -.- |
/azp run |
Commenter does not have sufficient privileges for PR 12601 in repo microsoft/vcpkg |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for the PR!
@thewhiteninja it looks like we should update xeus as well; I think that we need to either patch it to use |
Is it ok if I add a commit to this PR to add ciso646 to xeus ? |
@thewhiteninja yeah |
* Update to 3.9.0 * Update ports/nlohmann-json/CONTROL Co-authored-by: nicole mazzuca <mazzucan@outlook.com> * add a patch to fix the build and nlohmann-json checks. Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
Update nlohmann-json to 3.9.0