Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlcipher] Add new port #13786

Merged
merged 6 commits into from Oct 13, 2020
Merged

Conversation

SvenPStarFinanz
Copy link
Contributor

This is a sqlite edition with encryption, partially copied from the sqlite3 port.
The amalgamation files are built by the tclsh port.
Currently only Windows DLL support.

@ras0219
Copy link
Contributor

ras0219 commented Sep 28, 2020

Thanks for the PR!

Note to reviewers: this library is a replacement for sqlite3, so we cannot build it in CI.

@NancyLi1013 NancyLi1013 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Sep 29, 2020
ports/sqlcipher/portfile.cmake Outdated Show resolved Hide resolved
scripts/ci.baseline.txt Outdated Show resolved Hide resolved
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Sep 30, 2020
@NancyLi1013
Copy link
Contributor

I have installed sqlcipher on my local and the headers (sqlite3.h sqlite3xt.h) are installed in /include/sqlcipher/ directory. There is only one library named sqlcipher.lib.

I also installed sqlite3 and the headers (sqlite3.h sqlite3xt.h) are installed in include/` directory.

So I think these two points have no conflicts with each other. There is no need to skip the build on our CI.

@dan-shaw
Copy link
Contributor

dan-shaw commented Oct 2, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dan-shaw
Copy link
Contributor

dan-shaw commented Oct 6, 2020

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@dan-shaw dan-shaw merged commit 50fb30f into microsoft:master Oct 13, 2020
@jonboh
Copy link

jonboh commented Jul 7, 2022

@SvenPStarFinanz do you remember why this is not valid for static builds?

@SvenPStarFinanz
Copy link
Contributor Author

@jonboh Sorry, I would have to relearn into it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants