New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fontconfig] Add cflags in tools build command #17019
Merged
strega-nil-ms
merged 13 commits into
microsoft:master
from
xandox:fontconfig_cflags_pr_15605
May 5, 2021
Merged
[fontconfig] Add cflags in tools build command #17019
strega-nil-ms
merged 13 commits into
microsoft:master
from
xandox:fontconfig_cflags_pr_15605
May 5, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xandox
changed the title
add clags in tools build command
add cflags in tools build command
Apr 1, 2021
xandox
changed the title
add cflags in tools build command
fontconfig add cflags in tools build command
Apr 1, 2021
NancyLi1013
changed the title
fontconfig add cflags in tools build command
[fontconfig] Add cflags in tools build command
Apr 2, 2021
NancyLi1013
added
the
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
label
Apr 2, 2021
NancyLi1013
approved these changes
Apr 2, 2021
vicroms
added
requires:author-response
and removed
info:reviewed
Pull Request changes follow basic guidelines
labels
Apr 9, 2021
@xandox please pull the latest commit and run |
Seems you missed the changes in Could you please add it back? @xandox |
NancyLi1013
approved these changes
Apr 21, 2021
NancyLi1013
added
info:reviewed
Pull Request changes follow basic guidelines
and removed
requires:author-response
labels
Apr 21, 2021
LGTM now, thanks for your PR @xandox. |
ras0219-msft
requested changes
Apr 23, 2021
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
@xandox could you rebase on head? thanks! |
…into fontconfig_cflags_pr_15605
up |
Thanks @xandox! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:port-feature
The issue is with a library, which is requesting new capabilities that didn’t exist
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add cflags in tools build command
What does your PR fix? Fixes # fixes needs for PR [android] vcpkg_configure_make correct set flags for android build #15605
Which triplets are supported/not supported? same
Have you updated the CI baseline? no
Does your PR follow the maintainer guide? yes