Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fontconfig] Add cflags in tools build command #17019

Merged
merged 13 commits into from May 5, 2021

Conversation

xandox
Copy link
Contributor

@xandox xandox commented Apr 1, 2021

add cflags in tools build command

@xandox xandox changed the title add clags in tools build command add cflags in tools build command Apr 1, 2021
@xandox xandox changed the title add cflags in tools build command fontconfig add cflags in tools build command Apr 1, 2021
@NancyLi1013 NancyLi1013 self-assigned this Apr 2, 2021
@NancyLi1013 NancyLi1013 changed the title fontconfig add cflags in tools build command [fontconfig] Add cflags in tools build command Apr 2, 2021
@NancyLi1013 NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Apr 2, 2021
@NancyLi1013 NancyLi1013 added the info:reviewed Pull Request changes follow basic guidelines label Apr 2, 2021
@vicroms vicroms added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Apr 9, 2021
@vicroms
Copy link
Member

vicroms commented Apr 9, 2021

@xandox please pull the latest commit and run vcpkg x-add-version again

@NancyLi1013
Copy link
Contributor

Seems you missed the changes in ports/fontconfig/CONTROL file.

Could you please add it back? @xandox

@NancyLi1013 NancyLi1013 added info:reviewed Pull Request changes follow basic guidelines and removed requires:author-response labels Apr 21, 2021
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your PR @xandox.

versions/f-/fontconfig.json Outdated Show resolved Hide resolved
Co-authored-by: Robert Schumacher <roschuma@microsoft.com>
@strega-nil-ms
Copy link
Contributor

@xandox could you rebase on head? thanks!

@xandox
Copy link
Contributor Author

xandox commented May 5, 2021

up

@strega-nil-ms strega-nil-ms merged commit 706ab2a into microsoft:master May 5, 2021
@strega-nil-ms
Copy link
Contributor

Thanks @xandox!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants