Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg docs] Update readme.md #18253

Merged
merged 3 commits into from Jun 3, 2021
Merged

[vcpkg docs] Update readme.md #18253

merged 3 commits into from Jun 3, 2021

Conversation

PhoebeHui
Copy link
Contributor

Fixes #18191
Fixes #18231

  1. The ' .\vcpkg\vcpkg install package:x64-windows' in readme confuse the users, update it to make things clearer to reader.
  2. The readthedocs.io is broken, since issue Migrate documentation from readthedocs to vcpkg website vcpkg/vcpkg.github.io#12 (comment) closed, so I think it's ready to update it in readme.

@PhoebeHui PhoebeHui added category:documentation To resolve the issue, documentation will need to be updated info:internal This PR or Issue was filed by the vcpkg team. labels Jun 3, 2021
ras0219-msft
ras0219-msft requested changes Jun 3, 2021
View reviewed changes
README.md Outdated Show resolved Hide resolved
@ras0219-msft ras0219-msft merged commit a7b8f58 into microsoft:master Jun 3, 2021
@ras0219-msft
Copy link
Contributor

Thanks!

@PhoebeHui PhoebeHui deleted the dev/Phoebe/readme branch June 17, 2021 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ras0219-msft ras0219-msft ras0219-msft approved these changes

Assignees

@NancyLi1013 NancyLi1013

Labels
category:documentation To resolve the issue, documentation will need to be updated info:internal This PR or Issue was filed by the vcpkg team.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Docs at readthedocs.io seem broken? DOC: Unclear command line format in README
3 participants
@PhoebeHui @ras0219-msft @NancyLi1013