[opentelemetry-cpp] New port #19536
Merged
[opentelemetry-cpp] New port #19536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 13, 2021 00:42
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
srgbtl
commented
Aug 12, 2021
JonLiu1993
added
the
category:new-port
JonLiu1993
requested changes
Aug 13, 2021
srgbtl
commented
Aug 13, 2021
Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for opentelemetry-cpp but no changes to version or port version.
-- Version: 1.0.0-rc4
-- Old SHA: 0bf29cff16d15505f732756f0bc435afb19f0c9b
-- New SHA: 48a68013162895d375237802712856bcd94c8609
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
added 2 commits
August 13, 2021 10:59
…nto opentelemetry-cpp
JonLiu1993
approved these changes
Aug 13, 2021
JonLiu1993
added
the
requires:all-feature-testing
|
@srgbtl ,Have you tested features in locally?I tested X64-Windows-static and x64-linux locally and both failed: |
|
@JonLiu1993 I thought that this work is automated by pipelines, so I haven't checked all of the features. |
CI does not test features |
|
All features were tested locally (Windows only) |
JonLiu1993
approved these changes
Aug 17, 2021
|
All features are tested successfully in the following triplet:
|
JonLiu1993
added
info:reviewed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Fixes [New Port Request] opentelemetry-cpp #15899
Which triplets are supported/not supported? Have you updated the CI baseline?
all, No
Does your PR follow the maintainer guide?
Yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?Yes
If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/