[boost] Fix generate-ports.ps1 to match the tree. - #29338
Merged
Billy O'Neal (BillyONeal) merged 1 commit intoFeb 1, 2023
Conversation
Added the ability for the 'default' port version to get a value in case they all change at once (as almost happened due to microsoft#29288) microsoft#28356 did not apply post-source stubs for url and locale. I suspect they were just forgotten to be checked in? microsoft#28617 did not record the port version change in generate-ports.ps1. Also fixed all files to have LF line endings. (since changing boost-vcpkg-helper version also changed all the other ports anyway) Also changed "When changing this file also update and run scripts/boost/generate-ports.ps1" to "Automatically generated by scripts/boost/generate-ports.ps1" because I think that better conveys the consequences (your changes will get nuked).
Billy O'Neal (BillyONeal)
added
category:port-bug
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Cheney Wang (Cheney-W)
approved these changes
Feb 1, 2023
Lily Wang (LilyWangLL)
approved these changes
Feb 1, 2023
Lily Wang (LilyWangLL)
added
the
info:needs-maintainer-attention
Robert Schumacher (ras0219-msft)
left a comment
Robert Schumacher (ras0219-msft)
left a comment
Contributor
There was a problem hiding this comment.
LGTM
Robert Schumacher (ras0219-msft)
approved these changes
Feb 1, 2023
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability for the 'default' port version to get a value in case they all change at once (as almost happened due to #29288)
#28356 did not apply post-source stubs for url and locale. I suspect they were just forgotten to be checked in?
#28617 did not record the port version change in generate-ports.ps1.
Also fixed all files to have LF line endings. (since changing boost-vcpkg-helper version also changed all the other ports anyway)
Also changed "When changing this file also update and run scripts/boost/generate-ports.ps1" to "Automatically generated by scripts/boost/generate-ports.ps1" because I think that better conveys the consequences (your changes will get nuked).