Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libsndfile] Fix cmake config not exist #33070

Merged
merged 2 commits into from
Aug 10, 2023
Merged

[libsndfile] Fix cmake config not exist #33070

merged 2 commits into from
Aug 10, 2023

Conversation

xiaozhuai
Copy link
Contributor

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Fix #33028

@FrankXie05 FrankXie05 added the category:port-bug The issue is with a library, which is something the port should already support label Aug 9, 2023
@FrankXie05 FrankXie05 added the info:reviewed Pull Request changes follow basic guidelines label Aug 10, 2023
@JavierMatosD JavierMatosD merged commit 65c013b into microsoft:master Aug 10, 2023
16 checks passed
@xiaozhuai xiaozhuai deleted the dev-libsndfile branch August 13, 2023 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dg0yt dg0yt dg0yt left review comments

@FrankXie05 FrankXie05 FrankXie05 approved these changes

Assignees

@LilyWangLL LilyWangLL

Labels
category:port-bug The issue is with a library, which is something the port should already support info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[libsndfile] build failure
5 participants
@xiaozhuai @dg0yt @FrankXie05 @JavierMatosD @LilyWangLL