Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpptrace] New port #34217

Merged
merged 82 commits into from
Nov 1, 2023
Merged

[cpptrace] New port #34217

merged 82 commits into from
Nov 1, 2023

Conversation

jeremy-rifkin
Copy link
Contributor

@jeremy-rifkin jeremy-rifkin commented Oct 2, 2023

This PR resumes work on #32826 to add https://github.com/jeremy-rifkin/cpptrace

  • Changes comply with the maintainer guide
  • The name of the port matches an existing name for this component on https://repology.org/ if possible, and/or is strongly associated with that component on search engines.
  • Optional dependencies are resolved in exactly one way. For example, if the component is built with CMake, all find_package calls are REQUIRED, are satisfied by vcpkg.json's declared dependencies, or disabled with CMAKE_DISABLE_FIND_PACKAGE_Xxx
  • The versioning scheme in vcpkg.json matches what upstream says.
  • The license declaration in vcpkg.json matches what upstream says.
  • The installed as the "copyright" file matches what upstream says.
  • The source code of the component installed comes from an authoritative source.
  • The generated "usage text" is accurate. See adding-usage for context.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is in the new port's versions file.
  • Only one version is added to each modified port's versions file.

@jeremy-rifkin jeremy-rifkin marked this pull request as ready for review October 2, 2023 20:58
@jeremy-rifkin jeremy-rifkin changed the title Jr/cpptrace Cpptrace Oct 2, 2023
@jeremy-rifkin jeremy-rifkin changed the title Cpptrace [cpptrace] New port Oct 2, 2023
@jeremy-rifkin
Copy link
Contributor Author

Not sure what's causing this issue

Co-authored-by: Kai Pastor <dg0yt@darc.de>
@jeremy-rifkin jeremy-rifkin mentioned this pull request Oct 9, 2023
11 tasks
@jeremy-rifkin jeremy-rifkin marked this pull request as draft November 1, 2023 00:43
@jeremy-rifkin jeremy-rifkin marked this pull request as ready for review November 1, 2023 03:04
@jeremy-rifkin
Copy link
Contributor Author

Hi @Adela0814 @dg0yt, I think this should now be good to go

@Adela0814 Adela0814 added the info:reviewed Pull Request changes follow basic guidelines label Nov 1, 2023
@Adela0814
Copy link
Contributor

Usage tested pass on x64-windows.

@JavierMatosD JavierMatosD merged commit 88818ef into microsoft:master Nov 1, 2023
15 checks passed
@jeremy-rifkin
Copy link
Contributor Author

Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants