Skip to content

[boost] Update to v1.84.0#35693

Merged
JavierMatosD merged 44 commits into
microsoft:masterfrom
yurybura:boost-1.84.0
Jan 22, 2024
Merged

[boost] Update to v1.84.0#35693
JavierMatosD merged 44 commits into
microsoft:masterfrom
yurybura:boost-1.84.0

Conversation

@yurybura

@yurybura yurybura commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

Release Notes: https://www.boost.org/users/history/version_1_84_0.html

Fixes #35685
Fixes #35187
Fixes #34982

  • Changes comply with the maintainer guide
  • SHA512s are updated for each updated download
  • The "supports" clause reflects platforms that may be fixed by this new version
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Comment thread ports/boost-accumulators/portfile.cmake Outdated
@Adela0814 Adela0814 added the category:port-update The issue is with a library, which is requesting update new revision label Dec 15, 2023
@BillyONeal

Copy link
Copy Markdown
Member

I kicked the macos machine that died but not restarting build since there were other failures

Adela0814
Adela0814 previously approved these changes Jan 10, 2024
@Adela0814 Adela0814 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Jan 10, 2024
@BillyONeal

Copy link
Copy Markdown
Member

I was forced to cancel this build as it's the last thing holding the before-patch-tuesday machines alive. I tried to merge with master for you but permission is denied for me to do so.

@yurybura

Copy link
Copy Markdown
Contributor Author

@BillyONeal Permission has been granted. Sorry I forgot about this check box..

@BillyONeal

Copy link
Copy Markdown
Member

@BillyONeal Permission has been granted. Sorry I forgot about this check box..

No problem!

@yurybura

Copy link
Copy Markdown
Contributor Author

@BillyONeal The master branch is suddenly broken. Each update of this PR requires a long rebuild of all checks (up to 16 hours). My changes have already passed all checks before. Could you start the review? Thanks!)

@dg0yt

dg0yt commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

@BillyONeal The master branch is suddenly broken. Each update of this PR requires a long rebuild of all checks (up to 16 hours). My changes have already passed all checks before. Could you start the review? Thanks!)

I don't think it is broken. But you may want to factor out the vcpkg-cmake-get-vars change. If it is really necessary to have it.

@dg0yt

dg0yt commented Jan 19, 2024

Copy link
Copy Markdown
Contributor

And there is #36259.

@yurybura

yurybura commented Jan 19, 2024

Copy link
Copy Markdown
Contributor Author

I don't think it is broken. But you may want to factor out the vcpkg-cmake-get-vars change. If it is really necessary to have it.

It is used to detect compiler version in ports/boost-cobalt/b2-options.cmake.

Updated: I asked about compile-related requirements but didn't get an answer: #35754

And there is #36259.

Yes I saw it. The local build of netgen without my changes also failed, but it breaks the CI checks of this PR.

@BillyONeal

Copy link
Copy Markdown
Member

@BillyONeal The master branch is suddenly broken. Each update of this PR requires a long rebuild of all checks (up to 16 hours). My changes have already passed all checks before. Could you start the review? Thanks!)

Under some circumstances we might be able to do special dispensation to ignore CI failures, but given that we had a compiler version change out from under this I'm not really comfortable skipping PR build.

@yurybura

Copy link
Copy Markdown
Contributor Author

@BillyONeal The master branch is suddenly broken. Each update of this PR requires a long rebuild of all checks (up to 16 hours). My changes have already passed all checks before. Could you start the review? Thanks!)

Under some circumstances we might be able to do special dispensation to ignore CI failures, but given that we had a compiler version change out from under this I'm not really comfortable skipping PR build.

Sure, thanks!

@JavierMatosD JavierMatosD merged commit 8ccb84d into microsoft:master Jan 22, 2024
@yurybura yurybura deleted the boost-1.84.0 branch January 22, 2024 19:38
Osyotr pushed a commit to Osyotr/vcpkg that referenced this pull request Jan 23, 2024
* [scripts] update Boost ports generation script, fixes microsoft#35187

* [boost] remove obsolete patches and re-generate ports

* update versions

* [boost] remove redundant vcpkg_minimum_required

* update versions

* [scripts/boost] update dependencies to config/checks, review b2-options.cmake files

* [boost-*] regenerate ports

* [boost-locale] fix patch

* update versions

* [boost-serialization] fix checks

* update version

* [boost-*] better fixes related to the config checks

* update version

* [boost-cobalt] fix build

* update versions

* [liblas] Boost v1.84.0 requires C++11

* [pcl] fix Unix build

* add versions

* [vcpkg-cmake-get-vars] add CMAKE_<LANG>_COMPILER_VERSION

* [boost-cobalt] detect compiler

* [coin] force C++11

* [json5-parser] force C++11

* add versions

* [boost-cobalt] exclude iOS and Android platforms due to C++ Concepts library is not supported

* [gtsam] force C++11

* [kenlm] force C++11

* [quickfast] force C++11

* [liblas] force C++11

* update versions

* [boost] re-generate port

* update version

* [kenlm] revert changes

* [boost-cobalt] exclude OSX

* update versions

* [plc] remove useless patch after merge

* update versions after merge

---------

Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
@yihuajack

Copy link
Copy Markdown

Boost version on https://vcpkg.io/en/packages is still not updated (1.83.0)

TomKatom pushed a commit to TomKatom/vcpkg that referenced this pull request Feb 23, 2024
* [scripts] update Boost ports generation script, fixes microsoft#35187

* [boost] remove obsolete patches and re-generate ports

* update versions

* [boost] remove redundant vcpkg_minimum_required

* update versions

* [scripts/boost] update dependencies to config/checks, review b2-options.cmake files

* [boost-*] regenerate ports

* [boost-locale] fix patch

* update versions

* [boost-serialization] fix checks

* update version

* [boost-*] better fixes related to the config checks

* update version

* [boost-cobalt] fix build

* update versions

* [liblas] Boost v1.84.0 requires C++11

* [pcl] fix Unix build

* add versions

* [vcpkg-cmake-get-vars] add CMAKE_<LANG>_COMPILER_VERSION

* [boost-cobalt] detect compiler

* [coin] force C++11

* [json5-parser] force C++11

* add versions

* [boost-cobalt] exclude iOS and Android platforms due to C++ Concepts library is not supported

* [gtsam] force C++11

* [kenlm] force C++11

* [quickfast] force C++11

* [liblas] force C++11

* update versions

* [boost] re-generate port

* update version

* [kenlm] revert changes

* [boost-cobalt] exclude OSX

* update versions

* [plc] remove useless patch after merge

* update versions after merge

---------

Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
@moritz-h moritz-h mentioned this pull request May 7, 2024
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

boost-pfr dependency isn't sufficient to use Boost::pfr [boost-beast] update to 1.84

7 participants