Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sdl2-mixer]Fix usage issue. #8496

Merged
merged 2 commits into from Oct 9, 2019

Conversation

@JackBoosY
Copy link
Contributor

commented Oct 8, 2019

  1. Delete the absolute path of the dependent libraries.
  2. Use dynamic library suffix when building dynamic library.

Related: #8429.

@JackBoosY JackBoosY added the internal label Oct 8, 2019
@JackBoosY JackBoosY requested a review from PhoebeHui Oct 8, 2019
@JackBoosY

This comment has been minimized.

Copy link
Contributor Author

commented Oct 8, 2019

@tannergooding Can you test it? Thanks.

@JackBoosY JackBoosY changed the title [sdl2-mixer]Delete the absolute path of the dependent libraries. [sdl2-mixer]Fix usage issue. Oct 8, 2019
@JackBoosY JackBoosY marked this pull request as ready for review Oct 8, 2019
@tannergooding

This comment has been minimized.

Copy link
Member

commented Oct 8, 2019

Can you test it? Thanks.

Doing so now.

Copy link
Member

left a comment

Works as expected. Thanks!

@vicroms vicroms merged commit 31458d8 into microsoft:master Oct 9, 2019
4 checks passed
4 checks passed
license/cla All CLA requirements met.
Details
vcpkg-Linux-PR #15458 succeeded
Details
vcpkg-osx-PR #15460 succeeded
Details
vcpkg-windows-PR #15459 succeeded
Details
@vicroms vicroms self-assigned this Oct 9, 2019
@JackBoosY JackBoosY deleted the JackBoosY:dev/jack/8429 branch Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.