Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proj4] Update to version 6.2.0 #8621

Merged
merged 2 commits into from Oct 23, 2019
Merged

Conversation

ShinNoNoir
Copy link
Contributor

@ShinNoNoir ShinNoNoir commented Oct 16, 2019

This PR updates proj4 from 4.9 to 6.2.

This newer version, however, introduces some breaking changes:

  • The use of proj_api.h has now been deprecated. Using it will result in a compile-time error, unless ACCEPT_USE_OF_DEPRECATED_PROJ_API_H has been defined. The following ports have been updated as well to accommodate this change:
    • libgeotiff
    • libspatialite
  • The private internal header file projects.h has been removed. The vtk package was using it. A future release will address this issue. In the meantime, the port has been adjusted to use this patch.

Edit: These breaking changes were addressed in #7917.

Additionally, this PR changes gdal's CONTROL file to depend on proj4, not on proj.

@JackBoosY
Copy link
Contributor

Well, we have a PR #7917 to solve this, but version is 6.1.1

@JackBoosY
Copy link
Contributor

So, #7917 has been merged, plz merge it to your branch. Thanks.

@ShinNoNoir
Copy link
Contributor Author

Some (or parts of) of my commits are obsolete and will result in a merge conflict. I'll look into them next week when I have time to work on this PR again.

@ShinNoNoir
Copy link
Contributor Author

Brief update: I've rebased this branch onto the master branch on my local machine and resolved any conflicts. It seems to compile, but I'm still currently running some tests. I might be able to push my changes to the remote branch by tomorrow.

@ShinNoNoir
Copy link
Contributor Author

I've resolved the conflicts and pushed the new commits. The delta has become quite small. 😅

ports/gdal/CONTROL Show resolved Hide resolved
@vicroms vicroms merged commit 9354e07 into microsoft:master Oct 23, 2019
@ShinNoNoir ShinNoNoir deleted the proj4-6.2.0 branch October 24, 2019 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants