Regression fix: Check if globalState has the persisted editors before attempting to load #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check if globalState has the persisted editors before attempting to load
PrashanthCorp
commented
Mar 23, 2018
| } else if (editorNode.treeItem instanceof DocDBDocumentTreeItem) { | ||
| editor = new DocDBDocumentNodeEditor(<IAzureNode<DocDBDocumentTreeItem>>editorNode); | ||
| } else if (editorNode.treeItem instanceof MongoDocumentTreeItem) { | ||
| editor = new MongoDocumentNodeEditor(<IAzureNode<MongoDocumentTreeItem>>editorNode); |
There was a problem hiding this comment.
The diff is actually much smaller. Just inserting an if check in line 91, and else block at 109.
There was a problem hiding this comment.
View it this way: https://github.com/Microsoft/vscode-cosmosdb/pull/436/files?w=1
ejizba
approved these changes
Mar 23, 2018
StephenWeatherford
approved these changes
Mar 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #372