Add setting to allow user to change timeout. #900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
package.json
Outdated
| @@ -765,6 +765,11 @@ | |||
| "description": "Command to execute or full path to folder and executable to start the Mongo shell, needed by some Mongo scrapbook commands. If empty, will search in the system path for 'mongo'.", | |||
| "default": null | |||
| }, | |||
| "mongo.shell.timeoutInMilliseconds": { | |||
| "type": "number", | |||
| "description": "The duration allowed (in milliseconds) for the mongo shell to execute a command. Default value is 5 seconds", | |||
There was a problem hiding this comment.
I like "inMilliseconds" for variable names, but not so sure users will like it for options. I'd go with simple mongo.shell.timeout
There was a problem hiding this comment.
Mongo in 'Mongo shell'?
There was a problem hiding this comment.
If you're going to get rid of "inMilliseconds" I would make the timeout based on seconds. I feel like that's much more common for these types of settings
There was a problem hiding this comment.
Current settings are mixed:
But I'm good with seconds.
StephenWeatherford
approved these changes
Oct 24, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #809