Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find All References doesn't work in inactive regions #5398

Open
sean-mcmanus opened this issue May 1, 2020 · 2 comments
Open

Find All References doesn't work in inactive regions #5398

sean-mcmanus opened this issue May 1, 2020 · 2 comments
Labels
bug Feature: Find All References Find All References, Peek References, Rename Language Service Works in VS So we'd need to fix it for VS Code to reach parity.
Milestone
Unification

Comments

@sean-mcmanus
Copy link
Collaborator

sean-mcmanus commented May 1, 2020 •
edited

It works in VS, although it appears all the results will be unconfirmed references. It's possible it doesn't work for VS Code because the references UI expects at last 1 confirmed references (or it could be a backend issue due to type info not being available at the cursor location). So the "unification" work may or may not fix this.

Related to #3108
@sean-mcmanus sean-mcmanus added bug Language Service Works in VS So we'd need to fix it for VS Code to reach parity. Feature: Find All References Find All References, Peek References, Rename labels May 1, 2020
@sean-mcmanus sean-mcmanus mentioned this issue May 1, 2020
Open
@bobbrow bobbrow added this to the 0.30.0 milestone May 14, 2020
@bobbrow bobbrow added this to To Do in 1.0.0 Jun 12, 2020
@bobbrow bobbrow moved this from To Do to Triage in 1.0.0 Jul 14, 2020
@bobbrow bobbrow removed this from Triage in 1.0.0 Jul 30, 2020
@bobbrow bobbrow modified the milestones: 0.30.0, Unification Jul 30, 2020
@cohenav1
Copy link

Is there any update?

@sean-mcmanus
Copy link
Collaborator Author

No.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Feature: Find All References Find All References, Peek References, Rename Language Service Works in VS So we'd need to fix it for VS Code to reach parity.
Projects
None yet
Milestone
Unification
Development

No branches or pull requests
3 participants
@bobbrow @sean-mcmanus @cohenav1