Skip to content

Conversation

@dhruvil009
Copy link
Contributor

  • Rename no_suitable_complier to no_suitable_compiler in [Extension/src/nativeStrings.json]
  • Update all referencing i18n files to match the new key.
  • This change ensures the generated C++ header and TypeScript code will use the correct spelling.

@dhruvil009 dhruvil009 requested a review from a team as a code owner November 24, 2025 23:16
@github-project-automation github-project-automation bot moved this to Pull Request in cpptools Nov 24, 2025
@sean-mcmanus
Copy link
Contributor

I've created a cpptools change to match this. FYI, this change only affects our internal enum values and not any user-facing string.

@sean-mcmanus
Copy link
Contributor

@dhruvil009 It wants you to respond regarding the Contributor License Agreement(CLA)

@dhruvil009
Copy link
Contributor Author

@microsoft-github-policy-service agree

@dhruvil009
Copy link
Contributor Author

I've created a cpptools change to match this. FYI, this change only affects our internal enum values and not any user-facing string.

Thanks for the review and for updating the corresponding cpptools change, @sean-mcmanus!

@dhruvil009 dhruvil009 closed this Nov 25, 2025
@dhruvil009 dhruvil009 reopened this Nov 25, 2025
@dhruvil009
Copy link
Contributor Author

@dhruvil009 It wants you to respond regarding the Contributor License Agreement(CLA)

I have responded to CLA. I don’t have permission to merge this change myself, so whenever it’s convenient, could someone with write access merge it for me? Let me know if you’d like me to do anything else on my side.

@sean-mcmanus sean-mcmanus merged commit dbb3e72 into microsoft:main Nov 25, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Pull Request to Done in cpptools Nov 25, 2025
sean-mcmanus added a commit that referenced this pull request Dec 2, 2025
* put standard library file associations in package.json (#14002)

* Fix incorrect comma in settings string. (#14005)

* Update IntelliSense strings (translations are available yet). (#14020)

* Enable setting the VS dev environment without running from Dev Command Prompt (#13571)

* For VS 18.0 and above, use "Insiders" instead of "Preview" (#14022)

* Adding telemetry for devcmd environment usage (#14023)

* Update changelog and version for 1.29.0. (#14028)

* Update changelog and version for 1.29.0.

* Update TPN. (#14029)

* Update changelog (2nd time). (#14032)

* Update IntelliSense loc strings. (#14038)

* Update localization (#14039)

* Localization - Translated Strings

* Some fixes.

* Remove \t.

---------

Co-authored-by: csigs <csigs@users.noreply.github.com>

* Update the msvc version to 1950. (#14042)

* Retry build files task in cg.yml (#14043)

* Retry build files.

* Update changelog for 1.29.1. (#14058)

* Bump js-yaml from 4.1.0 to 4.1.1 in /Extension (#14060)

Bumps [js-yaml](https://github.com/nodeca/js-yaml) from 4.1.0 to 4.1.1.
- [Changelog](https://github.com/nodeca/js-yaml/blob/master/CHANGELOG.md)
- [Commits](nodeca/js-yaml@4.1.0...4.1.1)

---
updated-dependencies:
- dependency-name: js-yaml
  dependency-version: 4.1.1
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update js-yaml for github actions. (#14061)

* Fix typo "no_suitable_complier" in nativeStrings.json (#14064)

* Update changelog and verison for 1.29.2. (#14070)

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Bob Brown <bobbrow@users.noreply.github.com>
Co-authored-by: csigs <csigs@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Dhruvil Shah <dshah4@ncsu.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants