From ff5ab0ea879fa9f6f504a46e055e7635e61a5d0b Mon Sep 17 00:00:00 2001 From: Sean McManus Date: Wed, 8 May 2019 12:16:41 -0700 Subject: [PATCH 1/2] Add telemetry for missing binaries. --- Extension/src/LanguageServer/client.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/Extension/src/LanguageServer/client.ts b/Extension/src/LanguageServer/client.ts index 243a38174..7da323a52 100644 --- a/Extension/src/LanguageServer/client.ts +++ b/Extension/src/LanguageServer/client.ts @@ -402,6 +402,7 @@ class DefaultClient implements Client { let serverModule: string = getLanguageServerFileName(); let exeExists: boolean = fs.existsSync(serverModule); if (!exeExists) { + telemetry.logLanguageServerEvent("missingBinary"); throw String('Missing binary at ' + serverModule); } let serverName: string = this.getName(workspaceFolder); From 3e4ba54a92b14d7cde23019d4f2f85f7712f1d74 Mon Sep 17 00:00:00 2001 From: Sean McManus Date: Fri, 10 May 2019 14:40:03 -0700 Subject: [PATCH 2/2] Change telemetry name. --- Extension/src/LanguageServer/client.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Extension/src/LanguageServer/client.ts b/Extension/src/LanguageServer/client.ts index 7da323a52..d7481145f 100644 --- a/Extension/src/LanguageServer/client.ts +++ b/Extension/src/LanguageServer/client.ts @@ -402,7 +402,7 @@ class DefaultClient implements Client { let serverModule: string = getLanguageServerFileName(); let exeExists: boolean = fs.existsSync(serverModule); if (!exeExists) { - telemetry.logLanguageServerEvent("missingBinary"); + telemetry.logLanguageServerEvent("missingLanguageServerBinary"); throw String('Missing binary at ' + serverModule); } let serverName: string = this.getName(workspaceFolder);