Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for parsing @apply rules in SCSS #194

Merged
merged 1 commit into from Feb 17, 2020

Conversation

@jorgecasar
Copy link

jorgecasar commented Nov 20, 2019

Related with #8 into SCSS files. This remove the error of use @apply inside SCSS.

Jorge del Casar
@msftclas

This comment has been minimized.

Copy link

msftclas commented Nov 20, 2019

CLA assistant check
All CLA requirements met.

@aeschli

This comment has been minimized.

Copy link
Contributor

aeschli commented Feb 17, 2020

I don't see any mentioning of @apply in https://sass-lang.com/documentation/at-rules/. Should it rather be added to css (with a deprecated warning)?

@jorgecasar

This comment has been minimized.

Copy link
Author

jorgecasar commented Feb 17, 2020

It is a deprecated css standard, that is supported in CSS (#10), and doesn't work in SCSS files.

@aeschli

This comment has been minimized.

Copy link
Contributor

aeschli commented Feb 17, 2020

Oh, now I see. Thanks @jorgecasar !

@aeschli aeschli merged commit 3e16cdb into microsoft:master Feb 17, 2020
6 checks passed
6 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
microsoft.vscode-css-languageservice Build #20191120.1 succeeded
Details
microsoft.vscode-css-languageservice (Job linux) Job linux succeeded
Details
microsoft.vscode-css-languageservice (Job mac) Job mac succeeded
Details
microsoft.vscode-css-languageservice (Job windows) Job windows succeeded
Details
@aeschli aeschli added this to the February 2020 milestone Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.