Added pwsh az function container

[brettmillerb]

Good afternoon

I noticed that there was no Azure Functions PowerShell container available so I used the C# .NET core container and added Pwsh 6.2.3 to it in the dockerfile.

I'm by no means fluent with docker but I have tested this and it builds successfully but there is an error with setting the locale. Not sure if this is an ENV issue that needs to be resolved.

[106207 ms] perl: warning: Setting locale failed.
perl: warning: Please check that your locale settings:
        LANGUAGE = (unset),
        LC_ALL = "en_US.UTF-8",
        LANG = "en_US.UTF-8"
    are supported and installed on your system.
perl: warning: Falling back to the standard locale ("C").

The container still functions as normal and I can run and debug a local PowerShell Azure functions.

Please let me know if there are any changes required or if there's anything I have missed.

[TylerLeonhardt]

Looking good!

[Chuxel]

@brettmillerb Thanks so much for the contribution! That's awesome.

@TylerLeonhardt makes some great suggestions.

One other that I would add is we're typically not specifying the full version number in the dev container name unless we intend there to be more than one. Even then, it typically is a major release or version number that breaks compatibility. e.g. for .NET, that's 2.1.x, 2.2.x, 3.0.x, etc. For Node.js, its 10.x.x, 12.x.x. This allows people to still get back to the README when the minor or break-fix part of the version number is increased.

Perhaps this should be containers/azure-functions-pwsh-6 ?

[brettmillerb]

Made the recommendations by @TylerLeonhardt and renamed the parent folder to major version. Next version will be .NET core 3.0 and powershell 7 GA hopefully.

Let me know if there's anything else @Chuxel 🙂

[Chuxel]

Looks good - One quick question. Given .NET 2.2 is EOL Jan 1st 2020, should this use the LTS 2.1 SDK?

[TylerLeonhardt]

@Chuxel the PowerShell worker targets netcoreapp2.2 so I don't think we can do that.

[TylerLeonhardt]

LGTM

[Chuxel]

Thanks for the clarification! Merging.

[bergmeister]

@TylerLeonhardt @brettmillerb Since the PowerShell worker uses .Net Core 2.1 (see here), 2.2 does not make any sense and has been deprecated in December. The template should've really targeted 2.1. I opened this PR: #183