Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "Copy full tag" command, helpful for things like Dive, etc. #1426

Open
sandipchitale opened this issue Nov 13, 2019 · 12 comments
Labels
Milestone

Comments

@sandipchitale
Copy link

@sandipchitale sandipchitale commented Nov 13, 2019

Checkout this VSCode extension that integrates with dive command. The dive command enables the exploration of layers in a Docker file. This extension also adds the Dive command with the image tag node in Docker View:Images Viewlet tree context menu.

@bwateratmsft

This comment has been minimized.

Copy link
Contributor

@bwateratmsft bwateratmsft commented Nov 13, 2019

Did you mean to link another VSCode extension?

@sandipchitale

This comment has been minimized.

@bwateratmsft

This comment has been minimized.

Copy link
Contributor

@bwateratmsft bwateratmsft commented Nov 13, 2019

Is this just promoting your extension? GitHub issues are not the right place for that.

@sandipchitale

This comment has been minimized.

Copy link
Author

@sandipchitale sandipchitale commented Nov 13, 2019

Wanted to make user of your extension aware of additional extension on top.

@bwateratmsft

This comment has been minimized.

Copy link
Contributor

@bwateratmsft bwateratmsft commented Nov 13, 2019

We appreciate the additional features but I'm not sure issues are the right place for this. @BigMorty do you think we can add a page on the Wiki with links to some other extensions users might be interested in, like this one and probably also Remote - Containers?

@bwateratmsft

This comment has been minimized.

Copy link
Contributor

@bwateratmsft bwateratmsft commented Nov 13, 2019

@dbreshears suggested, if you would like, you can also submit a PR into this repo to add this feature. It's up to you.

@sandipchitale

This comment has been minimized.

Copy link
Author

@sandipchitale sandipchitale commented Nov 14, 2019

Ok. I will look into it.

@sandipchitale

This comment has been minimized.

Copy link
Author

@sandipchitale sandipchitale commented Nov 14, 2019

Filed pull request: #1428

@dbreshears

This comment has been minimized.

Copy link
Member

@dbreshears dbreshears commented Nov 15, 2019

@sandipchitale Thank you for submitting a PR for the team to consider. There are two aspects of this PR that we discussed. The first being the "Copy Full Tag" which seems to be a good addition to the Docker extension itself. For the second aspect, where functionality is dependent on other downloads/utilities that we have no control over, we believe a better extensibility model is to encourage these extensions to build their functionality on top of the Docker extension, in a manner you have done. We are also in discussion of including a section on the wiki to provide links to such extensions.

Would you be willing to create a new PR with just the “Copy Full Tag” functionality?

@dbreshears dbreshears reopened this Nov 15, 2019
@sandipchitale

This comment has been minimized.

Copy link
Author

@sandipchitale sandipchitale commented Nov 15, 2019

Sure. I can do that.

And I find Copy Full Tag command really useful because that is the format once needs in other docker CLI commands.

And I guess I will keep my extension going then.

@sandipchitale

This comment has been minimized.

Copy link
Author

@sandipchitale sandipchitale commented Nov 15, 2019

Filed a new PR with Copy Full Tag command only. See: #1431

@bwateratmsft bwateratmsft changed the title INFO: Integration with dive command Add a "Copy full tag" command, helpful for things like Dive, etc. Nov 15, 2019
@bwateratmsft

This comment has been minimized.

Copy link
Contributor

@bwateratmsft bwateratmsft commented Nov 15, 2019

I changed the title based on our current plan.

@dbreshears dbreshears added this to the 0.10.0 milestone Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.