Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom values for COMPOSE_FILE_GLOB_PATTERN and DOCKERFILE_GLOB_PATTERN (issue #102) #904

Open
wants to merge 2 commits into
base: master
from

Conversation

@x13machine
Copy link

commented Apr 22, 2019

  • add setting docker.dockerfileGlobPattern for specifying COMPOSE_FILE_GLOB_PATTERN
  • add setting docker.composeFileGlobPattern for specifying COMPOSE_FILE_GLOB_PATTERN
  • add information about the settings in README.md

Fixes #102

@x13machine x13machine requested a review from microsoft/vscodeazuretools as a code owner Apr 22, 2019

@x13machine

This comment has been minimized.

Copy link
Author

commented Apr 22, 2019

oh there's a pull request for something similar. I'll look at that tomorrow.

@PrashanthCorp

This comment has been minimized.

Copy link
Contributor

commented Apr 22, 2019

@x13machine ,

Thanks for the PR! I've edited the description to refer to the issue it addresses.

I don't have a pull request on that yet, I have a commit on it as part of another branch I'm working on:
3e0b814

@x13machine

This comment has been minimized.

Copy link
Author

commented Apr 23, 2019

@PrashanthCorp I was talking about pr #248. I looked it and it does something different.

@PrashanthCorp

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

That PR does not make the glob_pattern configurable. See #248 (comment) for more context.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.