Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List of problems I found in the samples. #174

Closed
x13machine opened this issue Apr 16, 2019 · 6 comments

Comments

@x13machine
Copy link

commented Apr 16, 2019

I could probably fix most of them.

progress-sample

  1. npm run compile uses watch mode
  2. uses 0.1.0 launch.json version
  3. Could not find the task 'tsc: watch - tsconfig.json'. when running
  4. Second task is broken.
  5. .vscode-test should probably be added to .gitignore in my opinion.

lsp-multi-server-sample

  1. requires non-existent file /tsconfig.base.json to build.
  2. Could not find the task 'npm: watch:client'. when trying to run.

basic-multi-root-sample

  1. npm run compile uses watch mode.
  2. uses 0.1.0 launch.json version
  3. Could not find the task 'tsc: watch - tsconfig.json'. when trying to run.

fsprovider-sample

  1. uses 0.1.0 launch.json version

statusbar-sample

  1. uses 0.1.0 launch.json version

theme-sample

  1. uses 0.1.0 launch.json version

virtual-document-sample

  1. uses 0.1.0 launch.json version
  2. missing script compile

webpack-sample

  1. uses 0.1.0 launch.json version
  2. missing script compile

language-configuration-sample

  1. missing script compile

snippet-sample

  1. missing script compile

tree-view-sample

  1. error TS2345: Argument of type '{ focus: true; select: false; expand: boolean; }' is not assignable to parameter of type '{ select?: boolean; focus?: boolean; }'. when building

vim-sample

  1. missing script compile
@octref

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

@x13machine Thanks for spotting the problems!

For language configuration sample and snippet sample, you don't have to compile anything, so there's no "script compile".

I fixed everything else except these 4 errors:

@bpasero progress-sample and basic-multi-root-sample seems to be caused by you moving to tasks 2.0. Can you take a look?

@dbaeumer Can you take a look at lsp-multi-server-sample?

@sandy081 Can you take a look at tree-view-sample?

@octref octref assigned bpasero, dbaeumer and sandy081 and unassigned octref Apr 16, 2019

octref added a commit that referenced this issue Apr 16, 2019

@bpasero

This comment has been minimized.

Copy link
Member

commented Apr 16, 2019

@bpasero progress-sample and basic-multi-root-sample seems to be caused by you moving to tasks 2.0. Can you take a look?

@dbaeumer do you have documentation how to update to Tasks 2.0? I am sorry, but my knowledge in that area is very limited 👍

@dbaeumer

This comment has been minimized.

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Fixed the issue in lsp-multi-server-sample.

bpasero added a commit that referenced this issue Apr 18, 2019

bpasero added a commit that referenced this issue Apr 18, 2019

@bpasero bpasero removed their assignment Apr 18, 2019

@bpasero

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

Me too.

@dbaeumer dbaeumer removed their assignment Apr 18, 2019

@octref octref closed this in c42b8f3 Apr 18, 2019

@octref

This comment has been minimized.

Copy link
Member

commented Apr 18, 2019

@sandy081 I fixed that by updating vscode.d.ts to version 1.32.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.