Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make this generator work with require.resolve #179

Merged
merged 1 commit into from Jul 30, 2019

Conversation

@TomasHubelbauer
Copy link
Contributor

commented Jul 13, 2019

I followed Integrating Yeoman to learn how to run a generator programatically and noticed the code example there doesn't work with the VS Code generator. See yeoman/environment#116.

I worked around this by using path.join(__dirname, 'node_modules/generator-code/generators/app/index.js'), but I think there is no harm down in making this compatible with the guide.

I believe this should do it.

Make this generator work with require.resolve
I followed [Integrating Yeoman](https://yeoman.io/authoring/integrating-yeoman.html) to learn how to run a generator programatically and noticed the code example there doesn't work with the VS Code generator. See yeoman/environment#116.

I worked around this by using `path.join(__dirname, 'node_modules/generator-code/generators/app/index.js')`, but I think there is no harm down in making this compatible with the guide.

I believe this should do it.

@aeschli aeschli merged commit 6afebc1 into microsoft:master Jul 30, 2019

2 checks passed

Microsoft.vscode-generator-code Build #20190713.1 succeeded
Details
license/cla All CLA requirements met.
@aeschli

This comment has been minimized.

Copy link
Contributor

commented Jul 30, 2019

@aeschli aeschli added this to the July 2019 milestone Jul 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.