This repository has been archived by the owner on Jul 15, 2023. It is now read-only.
stop registerLanguageFeatures cleanly when the binary is not installed #3015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The caller and getLanguageServerToolPath already detected the missing binary and offered to install the missing tool. So, simply returning immediately is ok, and prevents the warning messages such as not handling promise on time, or accessing non-existing property of tool.name in shouldUpdateLanguageServer.
ramya-rao-a
approved these changes
Feb 1, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The caller and getLanguageServerToolPath already detected the missing
binary and offered to install the missing tool. So, simply returning
immediately is ok, and prevents the warning messages such as not
handling promise on time, or accessing non-existing property of
tool.name in shouldUpdateLanguageServer.