chore: start locking down workflows - #16622
Merged
Merged
Conversation
Raymond Zhao (rzhao271)
changed the title
| VSC_JUPYTER_FORCE_LOGGING: 1 | ||
| VSC_JUPYTER_CI_TEST_VSC_CHANNEL: 'insiders' | ||
| uses: GabrielBB/xvfb-action@v1.7 | ||
| uses: GabrielBB/xvfb-action@b706e4e27b14669b486812790492dc50ca16b465 # v1.7 |
Contributor
There was a problem hiding this comment.
where do these values come from?
Contributor
There was a problem hiding this comment.
or rather, how did you collect them to be inserted here?
Contributor
Author
There was a problem hiding this comment.
I did it manually by looking up the repositories corresponding to the actions and then finding suitable commit SHAs, e.g. https://github.com/GabrielBB/xvfb-action/releases -> GabrielBB/xvfb-action@b706e4e.
zizmor does not trust actions outside of actions/* and encourages pinning to specific commit SHAs instead of version tags.
Contributor
|
unrelated test error |
Aaron Munger (amunger)
approved these changes
May 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies some zizmor audit suggestions to the workflow.