Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Falsy values are translated to null #215

Closed
svenefftinge opened this issue Jun 10, 2017 · 0 comments
Closed

Falsy values are translated to null #215

svenefftinge opened this issue Jun 10, 2017 · 0 comments

Comments

@svenefftinge
Copy link
Contributor

Message values like 0 or '' get translated to null.
svenefftinge added a commit to svenefftinge/vscode-languageserver-node that referenced this issue Jun 10, 2017
@svenefftinge
Make sure that only undefined arguments gets translated to null (fixes
6b86ac4 
 microsoft#215)
dbaeumer added a commit that referenced this issue Jun 12, 2017
@dbaeumer
Merge pull request #216 from svenefftinge/master
ddeae43 
Only convert `undefined` argument to null (fixes #215)
@hexa00 hexa00 mentioned this issue Jul 17, 2017
Closed
hexa00 pushed a commit to hexa00/theia that referenced this issue Aug 15, 2017
Update vscode-ws-jsonrpc to 0.0.1-alpha.5
40c506f 
This version is based on vscode-jsonrpc 3.3.0 which contains a fix to falsy
values that were translated to null. See:
microsoft/vscode-languageserver-node#215

This removes the need for workaround in the logger that uses indexes
starting at 1 rather than 0.

Signed-off-by: Antoine Tremblay <antoine.tremblay@ericsson.com>
hexa00 pushed a commit to eclipse-theia/theia that referenced this issue Aug 16, 2017
Update vscode-ws-jsonrpc to 0.0.1-alpha.5
4c812e0 
This version is based on vscode-jsonrpc 3.3.0 which contains a fix to falsy
values that were translated to null. See:
microsoft/vscode-languageserver-node#215

This removes the need for workaround in the logger that uses indexes
starting at 1 rather than 0.

Signed-off-by: Antoine Tremblay <antoine.tremblay@ericsson.com>
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 21, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@svenefftinge