Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add isPreferred to the CodeAction protocol. #489

Closed
wants to merge 3 commits into from

Conversation

@Jason3S
Copy link

commented Apr 25, 2019

See [vscode isPreferred discussion](microsoft/vscode#62110 (comment))
@msftclas

This comment has been minimized.

Copy link

commented Apr 25, 2019

CLA assistant check
All CLA requirements met.

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Apr 25, 2019

For this to be merged we need to update the spec as well (see https://github.com/Microsoft/language-server-protocol/blob/gh-pages/specification.md#L1). In addition I think this needs to be guarded by a client capability so the server can decided if it is worthwhile to compute the property (in this case inexpensive but this is how the spec works today).

@Jason3S

This comment has been minimized.

Copy link
Author

commented Apr 29, 2019

I have updated the spec and I added isPreferred to the Code Action capabilities. I hope this is what you meant.

@Jason3S

This comment has been minimized.

Copy link
Author

commented May 3, 2019

@dbaeumer Is there more I need to do?

types/src/main.ts Outdated Show resolved Hide resolved
@dbaeumer dbaeumer added this to the May 2019 milestone May 9, 2019
@Jason3S

This comment has been minimized.

@dbaeumer dbaeumer modified the milestones: May 2019, June 2019 Jun 4, 2019
@dbaeumer dbaeumer modified the milestones: June 2019, 3.15 Sep 10, 2019
@dbaeumer

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

Merged by hand with some minor modifications for consistency (e.g. isPreferredSupport).

@dbaeumer dbaeumer closed this Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.