Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send workspace folder diff upon listener notification #512

Merged
merged 2 commits into from Sep 20, 2019

Conversation

@tsmaeder
Copy link
Contributor

commented Aug 30, 2019

This is a fix for

Workspace folder changes are not sent to the server if they occur during initialisation #451

The gist of the fix is to remember the workspace folders sent to a language server during the "initialize" call and then send the diff between that state and the current WS folders when registering the workspace change listener.

Signed-off-by: Thomas Mäder tmader@redhat.com

@msftclas

This comment has been minimized.

Copy link

commented Aug 30, 2019

CLA assistant check
All CLA requirements met.

Signed-off-by: Thomas Mäder <tmader@redhat.com>
@tsmaeder tsmaeder force-pushed the tsmaeder:451_send_early_wsfolder_changes branch from 280b5c0 to f7ca6c1 Sep 4, 2019
@tsmaeder

This comment has been minimized.

Copy link
Contributor Author

commented Sep 4, 2019

Fixed lint errors

@@ -82,21 +92,40 @@ export class WorkspaceFoldersFeature implements DynamicFeature<undefined> {
id: id,
registerOptions: undefined
});
this.sendInitialEvent(workspace.workspaceFolders);

This comment has been minimized.

Copy link
@dbaeumer

dbaeumer Sep 17, 2019

Member

To make this consistent with other feature (e.g. DidOpenTextDocumentFeature) could we send the extra event in the register hook. Then we always have the same code pathes.

This comment has been minimized.

Copy link
@tsmaeder

tsmaeder Sep 18, 2019

Author Contributor

like so?

@dbaeumer

This comment has been minimized.

Copy link
Member

commented Sep 17, 2019

@tsmaeder thanks for the PR. I have one minor request. See above.

Signed-off-by: Thomas Mäder <tmader@redhat.com>
@dbaeumer dbaeumer merged commit 50ffd38 into microsoft:master Sep 20, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
Details
@dbaeumer dbaeumer added this to the 3.15 milestone Sep 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.