Skip to content

Feature Proposal: Inlay Hints - #609

Closed
Jeremy Kolb (kjeremy) wants to merge 1 commit into
microsoft:mainfrom
kjeremy:inlay-hints
Closed

Jeremy Kolb (kjeremy) wants to merge 1 commit into
microsoft:mainfrom
kjeremy:inlay-hints

Conversation

@kjeremy

Copy link
Copy Markdown
Contributor

This is the start of an "inlay hints" feature proposal. It is essentially the interface we use in rust-analyzer to achieve inlay hints (microsoft/vscode#16221)

I am working on this in my spare time (hence just the md for now) but would like to get feedback.

@msftclas

Microsoft Contribution License Agreements (msftclas) commented Apr 7, 2020 •

Copy link
Copy Markdown

CLA assistant check
All CLA requirements met.

@rcjsuen

Copy link
Copy Markdown
Contributor

I am working on this in my spare time (hence just the md for now) but would like to get feedback.

Jeremy Kolb (@kjeremy) I suggest you share your proposal as an issue in the microsoft/language-server-protocol repository.

@dbaeumer

Copy link
Copy Markdown
Member

Johannes Rieken (@jrieken) and Matt Bierner (@mjbvz) has something like this every come up in the VS Code API. I actually do like the feature especially for inferred types.

@kjeremy

Copy link
Copy Markdown
Contributor Author

A screen shot of this in action can be found at microsoft/vscode#16221 (comment)

@jrieken

Copy link
Copy Markdown

https://marketplace.visualstudio.com/items?itemName=sokra.ts-inline-types 👈 an extension that does this for TypeScript - tho, by creating yet another instance of the compiler

@KamasamaK

Copy link
Copy Markdown

Matt Bierner (@mjbvz) I see that you locked microsoft/vscode#16221. I agree that the nature of the comments mostly amounted to noise, but locking also prevents further actual +1s on the opening post.

@mjbvz

Copy link
Copy Markdown

We are still tracking it. There were enough +1 and comments on the issue to know that it’s something users are interested in

@matklad

Copy link
Copy Markdown
Contributor

Something which I believe is missing form discussion so far is that one could (but not necessary should) go beyond plain text for hints:

image

@Veetaha

Copy link
Copy Markdown

Maybe we should move the discussion to microsoft/language-server-protocol#956?

@dbaeumer

Copy link
Copy Markdown
Member

Lets close this in favour of #772

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants