Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi line comments #1376

Closed
urandu opened this issue Oct 11, 2019 · 17 comments
Closed

Multi line comments #1376

urandu opened this issue Oct 11, 2019 · 17 comments
Labels
feature-request Request for new features or functionality upstream/vscode

Comments

@urandu
Copy link

urandu commented Oct 11, 2019

Currently on GitHub, it is possible to have multi line comments. It would be whorthwile to also have this feature on this extension.

I would be more than happy to take this up..

@RMacfarlane RMacfarlane added the feature-request Request for new features or functionality label Oct 11, 2019
@RMacfarlane
Copy link
Contributor

Yes, this would be great to have!

To get this to work will require some changes in VSCode, it controls the gutter that is used to add comments. It would need to add support for opening the comment editor from a selection.

@Chathula
Copy link

is there any update on this? waiting for this :(

@urandu
Copy link
Author

urandu commented Apr 30, 2020

@Chathula I will be pushing out a PR on this within a week from now

@ltshb
Copy link

ltshb commented Aug 5, 2020

@Chathula I will be pushing out a PR on this within a week from now

Any news on when this will be released ? I'd be very interested in this feature :-)

@selrond
Copy link

selrond commented Nov 17, 2020

@urandu have you made any progress?

@MarthinusBosman
Copy link

@urandu I believe this functionality worked a while back, but no longer does.

@gabrieledcjr
Copy link

@urandu any updates?

@urandu
Copy link
Author

urandu commented Apr 13, 2021

@gabrieledcjr @MarthinusBosman I'm testing this functionality ans should be able to publish a PR in the next few days. I will keep you posted.

@chaicesan
Copy link

What's the latest on this?

@7azycoder
Copy link

Any updates on this?

@zoltan-patchworks
Copy link

This feature would be really useful.

@irenepc
Copy link

irenepc commented Sep 17, 2021

I hope there'll be some more progress soon! Every time I make another attempt at using the PR tools in vscode I seem to get stuck on a new snag. This would be awesome to have!

@dsinni
Copy link

dsinni commented Sep 22, 2021

This would be a great to have. I keep finding myself having to go back to GitHub to make these comments, which takes away from the great convenience this provides otherwise.

Looking forward to this feature!

Maybe slightly off topic, but it would also be great to have UI for adding code suggestions in the comments similar to how it works on GitHub.

@Neykah
Copy link

Neykah commented Oct 22, 2021

Is there any update on this feature?
It would be really great to have.

@shamar-morrison
Copy link

Has there been any updates on this? Would love for it to get added

@alexr00
Copy link
Member

alexr00 commented Apr 1, 2022

Upstream issue: microsoft/vscode#146510

@alexr00
Copy link
Member

alexr00 commented Jun 21, 2022

The upstream issue is complete!

@alexr00 alexr00 closed this as completed Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality upstream/vscode
Projects
None yet
Development

No branches or pull requests