Skip to content
This repository has been archived by the owner on Dec 23, 2021. It is now read-only.

README change (more stuff for microbit) part 2 #274

Merged
merged 3 commits into from Mar 23, 2020

Conversation

vandyliu
Copy link
Contributor

@vandyliu vandyliu commented Mar 23, 2020

AB#34117

Description:

  • use absolute links instead of relative links
  • changed all usage of double quotes to single quotes for elements (eg. src="" to src='')
  • changed some alt names for images to be more specific

Limitations:

Please describe limitations of this PR

Testing:

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • My code has been formatted with npm run format and passes the checks in npm run check
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

Copy link

@nasadigital nasadigital left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

README.md Outdated Show resolved Hide resolved
Copy link
Contributor

@andreamah andreamah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks! 😁

@vandyliu vandyliu merged commit 240beef into dev Mar 23, 2020
@vandyliu vandyliu deleted the users/t-vali/readme-change-part2 branch March 23, 2020 18:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants