Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure we provide icon and contextualTitle properties for the test explorer #12325

Closed
luabud opened this issue Jun 12, 2020 · 1 comment
Closed
Labels
area-testing feature-request Request for new features or functionality needs spike Label for issues that need investigation before they can be worked on.

Comments

@luabud
Copy link
Member

luabud commented Jun 12, 2020

From VS Code's update 1.46:

https://code.visualstudio.com/updates/v1_46#_flexible-layout

For extension authors contributing views or view containers

When views are moved around the workbench, they sometimes need to be presented differently, either with an icon or extra context if they aren't in their default location. When contributing a view, authors may now provide an icon property and a contextualTitle. If not provided, these will default to the icon and title of the view container to which they are contributed.

We should check if we do it for test explorer, if not we should do it :)

@luabud luabud added feature-request Request for new features or functionality triage-needed Needs assignment to the proper sub-team labels Jun 12, 2020
@kimadeline kimadeline added area-testing needs spike Label for issues that need investigation before they can be worked on. labels Jun 16, 2020
@ghost ghost removed the triage-needed Needs assignment to the proper sub-team label Jun 16, 2020
@karthiknadig
Copy link
Member

Closing this as stale

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-testing feature-request Request for new features or functionality needs spike Label for issues that need investigation before they can be worked on.
Projects
None yet
Development

No branches or pull requests

3 participants