Adopt proposed API for test debug restart

[karthiknadig]

[eleanorjboyd]

here is the core issue we are using to make these changes: microsoft/vscode#214486

[eleanorjboyd]

Potential bug:

It seems that onTerminateDebugSession gets called for all runInstances known to the debugger from the reload state. See logs I recorded with these random distinct numbers to differentiate the run instances. You can see my first runInstance #426 is created then canceled (this is bc I have reloaded which we talked about was the right behavior). Then the reload spawns a new process right after (runInstance #721) which I never cancel or anything as the user but you can see onDidTerminateDebugSession is called on it either way. What is also interesting is the other runInstance numbers called for onDidTerminateDebugSession were from a previous run I had made when trying this same process before (#530 and #994). So those instances should be completely gone but they come back and get called again. Once I reload my vscode window previous instances disappear but as long as I am in a session, only instances are called again. From this it seems like onDidTerminateDebugSession is being called too many times and specifically is called too early for my regenerated instance on reload which causes a bug.

Logs from Run
[user: click debug]
created run instance Running Tests for Workspace(s):random: 426
launch debugger Running Tests for Workspace(s):random: 426
[user: click reload]
onCancellationRequested Running Tests for Workspace(s):random: 426
end run instance Running Tests for Workspace(s):random: 426
created run instance Running Tests for Workspace(s):random: 721
launch debugger Running Tests for Workspace(s):random: 721
info 15:44:48.684: Jupyter Extension: Ending debug session
onDidTerminateDebugSession : Running Tests for Workspace(s): random: 994
onDidTerminateDebugSession : Running Tests for Workspace(s): random: 530
onDidTerminateDebugSession : Running Tests for Workspace(s): random: 530 resolve
onDidTerminateDebugSession : Running Tests for Workspace(s): random: 426
onDidTerminateDebugSession : Running Tests for Workspace(s): random: 721
onDidTerminateDebugSession : Running Tests for Workspace(s): random: 721 resolve
end run instance Running Tests for Workspace(s): random: 721
{user screen is now on a new debug instance with the breakpoint hit waiting for user input}

[eleanorjboyd]

here is the core issue we are using to make these changes: microsoft/vscode#214486

[eleanorjboyd]

Potential bug:

It seems that onTerminateDebugSession gets called for all runInstances known to the debugger from the reload state. See logs I recorded with these random distinct numbers to differentiate the run instances. You can see my first runInstance #426 is created then canceled (this is bc I have reloaded which we talked about was the right behavior). Then the reload spawns a new process right after (runInstance #721) which I never cancel or anything as the user but you can see onDidTerminateDebugSession is called on it either way. What is also interesting is the other runInstance numbers called for onDidTerminateDebugSession were from a previous run I had made when trying this same process before (#530 and #994). So those instances should be completely gone but they come back and get called again. Once I reload my vscode window previous instances disappear but as long as I am in a session, only instances are called again. From this it seems like onDidTerminateDebugSession is being called too many times and specifically is called too early for my regenerated instance on reload which causes a bug.

Logs from Run
[user: click debug]
created run instance Running Tests for Workspace(s):random: 426
launch debugger Running Tests for Workspace(s):random: 426
[user: click reload]
onCancellationRequested Running Tests for Workspace(s):random: 426
end run instance Running Tests for Workspace(s):random: 426
created run instance Running Tests for Workspace(s):random: 721
launch debugger Running Tests for Workspace(s):random: 721
info 15:44:48.684: Jupyter Extension: Ending debug session
onDidTerminateDebugSession : Running Tests for Workspace(s): random: 994
onDidTerminateDebugSession : Running Tests for Workspace(s): random: 530
onDidTerminateDebugSession : Running Tests for Workspace(s): random: 530 resolve
onDidTerminateDebugSession : Running Tests for Workspace(s): random: 426
onDidTerminateDebugSession : Running Tests for Workspace(s): random: 721
onDidTerminateDebugSession : Running Tests for Workspace(s): random: 721 resolve
end run instance Running Tests for Workspace(s): random: 721
{user screen is now on a new debug instance with the breakpoint hit waiting for user input}

[eleanorjboyd]

this was a tracking issue- the verification should be done on related bugs like: #20520