Go to definition sometimes finds the correct definition twice on case-insensitive filesystems

[Trolldemorted]

Environment data

• VS Code version: 1.33.1
• Extension version (available under the Extensions sidebar): 2019.4.11987
• OS and version: W10 N Professional 1809 (Build 17763.437)
• Python version (& distribution if applicable, e.g. Anaconda): Python 3.7.3 64-bit
• Type of virtual environment used (N/A | venv | virtualenv | conda | ...): happens with and without virtualenv
• Relevant/affected Python packages and their versions: All with relative imports

Expected behaviour

Go to definition finds the one and only correct definition

Actual behaviour

Go to definition sometimes finds the correct definition twice on NFTS (and doesn't actually go to it since it found more than one)

Steps to reproduce:

1. Start VS code
2. try to go to a definition quickly (it appears to be racy, it fails only sometimes)

Logs

This bug does not trigger reliably enough for me to get some decent logs when it happens, but since #5507 did not yield any useful logs either I suspect there aren't any too.

[DonJayamanne]

Apologies for the delay.
Please could you let us know whether you have the following setting in your user or workspace settings.json file:

"python.jediEnabled": true/false

Note: Please check both your user and workspace settings file.

[Trolldemorted]

Sorry for the delay, I have lost my workspace but since I believe I didn't change anything intentionally I created a new one and had a look:

Workspace has jedi enabled, user does not. I assume this makes it a jedi bug? This appears to be the default setting, is it the recommended setting?

[ericsnowcurrently]

Just to make sure I've understood correctly, you have "python.jediEnabled": true in your workspace settings? The default is "true", meaning Jedi gets used unless you explicitly disable it. In the "Python" Output pane you will see a message about the language server starting if you have it enabled (by disabling Jedi).

Do you see the problem if you put "python.jediEnabled": false in your workspace settings?

[Trolldemorted]

Yes I have. So to use the language server, I have to explicitly disable jedi in every workspace, and thus this is a jedi issue?

It is very hard to reproduce this problem, I guess I'll just switch to your language server in all my workspaces. Thanks for your patience!