Skip to content

Install jupyter if its not found #6421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 10, 2019
Merged

Install jupyter if its not found #6421

merged 21 commits into from
Jul 10, 2019

Conversation

@DavidKutu
Copy link

@DavidKutu DavidKutu commented Jul 2, 2019 •
edited
Loading

For #5682

Prompts user to install jupyter if its not found, instead of showing an error.

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@DavidKutu DavidKutu self-assigned this Jul 2, 2019
rchiodo
rchiodo reviewed Jul 2, 2019
View reviewed changes
rchiodo
rchiodo reviewed Jul 2, 2019
View reviewed changes
rchiodo
rchiodo requested changes Jul 2, 2019
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕐

rchiodo
rchiodo reviewed Jul 3, 2019
View reviewed changes
rchiodo
rchiodo reviewed Jul 3, 2019
View reviewed changes
rchiodo
rchiodo reviewed Jul 3, 2019
View reviewed changes
rchiodo
rchiodo reviewed Jul 8, 2019
View reviewed changes
rchiodo
rchiodo approved these changes Jul 8, 2019
View reviewed changes
Copy link

@rchiodo rchiodo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo
Copy link

rchiodo commented Jul 8, 2019

@IanMatthewHuff is added to the review. #Closed

IanMatthewHuff
IanMatthewHuff reviewed Jul 8, 2019
View reviewed changes
IanMatthewHuff
IanMatthewHuff reviewed Jul 8, 2019
View reviewed changes
IanMatthewHuff
IanMatthewHuff reviewed Jul 9, 2019
View reviewed changes
@DavidKutu DavidKutu merged commit 58b5c80 into master Jul 10, 2019
@DavidKutu DavidKutu deleted the davidkutu/install_jupyter branch July 10, 2019 00:44
@lock lock bot locked as resolved and limited conversation to collaborators Jul 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@DonJayamanne DonJayamanne DonJayamanne left review comments

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

@rchiodo rchiodo rchiodo approved these changes

@joyceerhl joyceerhl Awaiting requested review from joyceerhl

Assignees

@DavidKutu DavidKutu

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@DavidKutu @rchiodo @IanMatthewHuff @DonJayamanne