From 2756aad9fa422c56308f81dd5114038e9ef57d5e Mon Sep 17 00:00:00 2001 From: Don Jayamanne Date: Wed, 15 Apr 2020 11:39:31 -0700 Subject: [PATCH 1/2] Ensure save works after saving untitled notebooks --- .../datascience/interactive-ipynb/nativeEditorProviderOld.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/client/datascience/interactive-ipynb/nativeEditorProviderOld.ts b/src/client/datascience/interactive-ipynb/nativeEditorProviderOld.ts index 1ed7109a3f10..794d76b0b389 100644 --- a/src/client/datascience/interactive-ipynb/nativeEditorProviderOld.ts +++ b/src/client/datascience/interactive-ipynb/nativeEditorProviderOld.ts @@ -66,6 +66,7 @@ export class NativeEditorProviderOld extends NativeEditorProvider { const customDocument = this.customDocuments.get(resource.fsPath); if (customDocument) { await this.saveAs(customDocument, targetResource); + this.customDocuments.set(targetResource.fsPath, { ...customDocument, uri: targetResource }); } } ) From 1e28a597c9eedf67199eacf19739259a1c1351a5 Mon Sep 17 00:00:00 2001 From: Don Jayamanne Date: Wed, 15 Apr 2020 11:49:37 -0700 Subject: [PATCH 2/2] Remove old document --- .../datascience/interactive-ipynb/nativeEditorProviderOld.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/client/datascience/interactive-ipynb/nativeEditorProviderOld.ts b/src/client/datascience/interactive-ipynb/nativeEditorProviderOld.ts index 794d76b0b389..fcdcea4afa2a 100644 --- a/src/client/datascience/interactive-ipynb/nativeEditorProviderOld.ts +++ b/src/client/datascience/interactive-ipynb/nativeEditorProviderOld.ts @@ -66,6 +66,7 @@ export class NativeEditorProviderOld extends NativeEditorProvider { const customDocument = this.customDocuments.get(resource.fsPath); if (customDocument) { await this.saveAs(customDocument, targetResource); + this.customDocuments.delete(resource.fsPath); this.customDocuments.set(targetResource.fsPath, { ...customDocument, uri: targetResource }); } }