From 4cacf9b445accc3204c3f705c35661ed8f0c7193 Mon Sep 17 00:00:00 2001 From: Ian Huff Date: Tue, 9 Jun 2020 08:16:20 -0700 Subject: [PATCH 1/2] fix continue event to run cell (#12211) Co-authored-by: Ian Huff --- news/2 Fixes/12155.md | 1 + .../interactive-ipynb/nativeEditorRunByLineListener.ts | 6 +++--- 2 files changed, 4 insertions(+), 3 deletions(-) create mode 100644 news/2 Fixes/12155.md diff --git a/news/2 Fixes/12155.md b/news/2 Fixes/12155.md new file mode 100644 index 000000000000..3473014c4b2c --- /dev/null +++ b/news/2 Fixes/12155.md @@ -0,0 +1 @@ +Fix debugger continue event to actually change a cell. \ No newline at end of file diff --git a/src/client/datascience/interactive-ipynb/nativeEditorRunByLineListener.ts b/src/client/datascience/interactive-ipynb/nativeEditorRunByLineListener.ts index 40403a0528f0..2051c09bea0a 100644 --- a/src/client/datascience/interactive-ipynb/nativeEditorRunByLineListener.ts +++ b/src/client/datascience/interactive-ipynb/nativeEditorRunByLineListener.ts @@ -105,18 +105,18 @@ export class NativeEditorRunByLineListener private async handleStep() { // User issued a step command. - this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: undefined }); + this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: this.currentCellBeingRun }); return this.debugService.step(); } private async handleContinue() { // User issued a continue command - this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: undefined }); + this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: this.currentCellBeingRun }); return this.debugService.continue(); } private async handleContinueEvent() { // Tell the ui to erase the current IP - this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: undefined }); + this.postEmitter.fire({ message: InteractiveWindowMessages.ShowContinue, payload: this.currentCellBeingRun }); } } From 566e19cb6aac4effaa4f13cab0f7e3c3c34a14e8 Mon Sep 17 00:00:00 2001 From: Ian Huff Date: Tue, 9 Jun 2020 09:22:25 -0700 Subject: [PATCH 2/2] update changelog and delete news file --- CHANGELOG.md | 2 ++ news/2 Fixes/12155.md | 1 - 2 files changed, 2 insertions(+), 1 deletion(-) delete mode 100644 news/2 Fixes/12155.md diff --git a/CHANGELOG.md b/CHANGELOG.md index 172078ed703c..f44320095159 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -90,6 +90,8 @@ ([#12169](https://github.com/Microsoft/vscode-python/issues/12169)) 1. Disable `Sort Imports` command in `Notebook Cells`. ([#12193](https://github.com/Microsoft/vscode-python/issues/12193)) +1. Fix debugger continue event to actually change a cell. + ([#12155](https://github.com/Microsoft/vscode-python/issues/12155)) ### Code Health diff --git a/news/2 Fixes/12155.md b/news/2 Fixes/12155.md deleted file mode 100644 index 3473014c4b2c..000000000000 --- a/news/2 Fixes/12155.md +++ /dev/null @@ -1 +0,0 @@ -Fix debugger continue event to actually change a cell. \ No newline at end of file