From 2a8f570e765f0ccce7c4ef80031d4a33966f3227 Mon Sep 17 00:00:00 2001 From: Shantnu Suman Date: Wed, 26 Aug 2020 01:49:32 +0530 Subject: [PATCH 1/6] Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window. (#13600) --- news/2 Fixes/13551.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 news/2 Fixes/13551.md diff --git a/news/2 Fixes/13551.md b/news/2 Fixes/13551.md new file mode 100644 index 000000000000..00ff15fcb848 --- /dev/null +++ b/news/2 Fixes/13551.md @@ -0,0 +1 @@ +Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window. From 7ee423cb64cb85768c918cc0dc28aeb4576adb70 Mon Sep 17 00:00:00 2001 From: Kim-Adeline Miguel <51720070+kimadeline@users.noreply.github.com> Date: Mon, 24 Aug 2020 15:55:57 -0700 Subject: [PATCH 2/6] Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing (#13554) * Update vscode-tas-client * Add experiment group enum * Add method to retrieve experiment values * Implementation + tests * News file * Update wording of the news entry * Add telemetry * More tests * No opting-in and out of this one * Don't fetch value if opted out, add tests * Address comments --- news/1 Enhancements/13535.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 news/1 Enhancements/13535.md diff --git a/news/1 Enhancements/13535.md b/news/1 Enhancements/13535.md new file mode 100644 index 000000000000..a496f632f66b --- /dev/null +++ b/news/1 Enhancements/13535.md @@ -0,0 +1 @@ +Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing. From f8a2905517bc924267d7c420636ff6a78725d73c Mon Sep 17 00:00:00 2001 From: Rich Chiodo Date: Fri, 21 Aug 2020 16:30:10 -0700 Subject: [PATCH 3/6] Fix save on close (#13567) * Pass model through command instead of URI in order to use directly * Add a test to verify we don't regress * Finish fixing tests * Add news entry * Fix unit tests --- news/2 Fixes/11711.md | 1 + 1 file changed, 1 insertion(+) create mode 100644 news/2 Fixes/11711.md diff --git a/news/2 Fixes/11711.md b/news/2 Fixes/11711.md new file mode 100644 index 000000000000..925b2acebf8c --- /dev/null +++ b/news/2 Fixes/11711.md @@ -0,0 +1 @@ +Fix saving during close and auto backup to actually save a notebook. \ No newline at end of file From b2de97c0286dc4fbe616722503eaade415dc9f09 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Tue, 25 Aug 2020 13:58:12 -0700 Subject: [PATCH 4/6] Update changelog and version for point release. --- news/1 Enhancements/13535.md | 1 - news/2 Fixes/11711.md | 1 - news/2 Fixes/13551.md | 1 - 3 files changed, 3 deletions(-) delete mode 100644 news/1 Enhancements/13535.md delete mode 100644 news/2 Fixes/11711.md delete mode 100644 news/2 Fixes/13551.md diff --git a/news/1 Enhancements/13535.md b/news/1 Enhancements/13535.md deleted file mode 100644 index a496f632f66b..000000000000 --- a/news/1 Enhancements/13535.md +++ /dev/null @@ -1 +0,0 @@ -Update "Tip" notification for new users to either show the existing tip, a link to a feedback survey or nothing. diff --git a/news/2 Fixes/11711.md b/news/2 Fixes/11711.md deleted file mode 100644 index 925b2acebf8c..000000000000 --- a/news/2 Fixes/11711.md +++ /dev/null @@ -1 +0,0 @@ -Fix saving during close and auto backup to actually save a notebook. \ No newline at end of file diff --git a/news/2 Fixes/13551.md b/news/2 Fixes/13551.md deleted file mode 100644 index 00ff15fcb848..000000000000 --- a/news/2 Fixes/13551.md +++ /dev/null @@ -1 +0,0 @@ -Show the server display string that the user is going to connect to after selecting a compute instance and reloading the window. From 9631e50fd933ce3fdd63238e9523c74a05fea992 Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Thu, 27 Aug 2020 16:30:11 -0700 Subject: [PATCH 5/6] Skip workspace virtual env service tests --- .../discovery/locators/workspaceVirtualEnvService.test.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/pythonEnvironments/discovery/locators/workspaceVirtualEnvService.test.ts b/src/test/pythonEnvironments/discovery/locators/workspaceVirtualEnvService.test.ts index 7bb93205ed0c..4f2a3408cd72 100644 --- a/src/test/pythonEnvironments/discovery/locators/workspaceVirtualEnvService.test.ts +++ b/src/test/pythonEnvironments/discovery/locators/workspaceVirtualEnvService.test.ts @@ -125,6 +125,8 @@ suite('Interpreters - Workspace VirtualEnv Service', function () { } suiteSetup(async function () { + this.skip(); + // skip for Python < 3, no venv support if (await isPythonVersionInProcess(undefined, '2')) { return this.skip(); From 87e6109cf061756d256bcd0ead5837781c74116f Mon Sep 17 00:00:00 2001 From: Karthik Nadig Date: Thu, 27 Aug 2020 16:42:36 -0700 Subject: [PATCH 6/6] Add link to issue for skipping --- .../discovery/locators/workspaceVirtualEnvService.test.ts | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/pythonEnvironments/discovery/locators/workspaceVirtualEnvService.test.ts b/src/test/pythonEnvironments/discovery/locators/workspaceVirtualEnvService.test.ts index 4f2a3408cd72..cf763c3ee2c0 100644 --- a/src/test/pythonEnvironments/discovery/locators/workspaceVirtualEnvService.test.ts +++ b/src/test/pythonEnvironments/discovery/locators/workspaceVirtualEnvService.test.ts @@ -125,6 +125,8 @@ suite('Interpreters - Workspace VirtualEnv Service', function () { } suiteSetup(async function () { + // Skipping test due to flaky ness + // see:https://github.com/microsoft/vscode-python/issues/13649 this.skip(); // skip for Python < 3, no venv support