diff --git a/news/2 Fixes/13706.md b/news/2 Fixes/13706.md new file mode 100644 index 000000000000..fb3074fa7820 --- /dev/null +++ b/news/2 Fixes/13706.md @@ -0,0 +1 @@ +Fix the behavior of the 'python.showStartPage' setting. diff --git a/src/client/common/configSettings.ts b/src/client/common/configSettings.ts index d0066f58b378..7473bcfcd952 100644 --- a/src/client/common/configSettings.ts +++ b/src/client/common/configSettings.ts @@ -544,6 +544,11 @@ export class PythonSettings implements IPythonSettings { this.datascience = dataScienceSettings; } + const showStartPage = pythonSettings.get('showStartPage'); + if (showStartPage !== undefined) { + this.showStartPage = showStartPage; + } + this.insidersChannel = pythonSettings.get('insidersChannel')!; } diff --git a/src/test/common/configSettings/configSettings.unit.test.ts b/src/test/common/configSettings/configSettings.unit.test.ts index 6a6cbc07cf91..c8e1b92042b5 100644 --- a/src/test/common/configSettings/configSettings.unit.test.ts +++ b/src/test/common/configSettings/configSettings.unit.test.ts @@ -47,7 +47,7 @@ suite('Python Settings', async () => { let settings: CustomPythonSettings; setup(() => { sinon.stub(EnvFileTelemetry, 'sendSettingTelemetry').returns(); - config = TypeMoq.Mock.ofType(undefined, TypeMoq.MockBehavior.Strict); + config = TypeMoq.Mock.ofType(undefined, TypeMoq.MockBehavior.Loose); expected = new CustomPythonSettings(undefined, new MockAutoSelectionService()); settings = new CustomPythonSettings(undefined, new MockAutoSelectionService()); expected.defaultInterpreterPath = 'python';