From d9a20b575e92c4123fe8cdc4bfe26e535f6a45fd Mon Sep 17 00:00:00 2001 From: Rich Chiodo Date: Tue, 9 Feb 2021 14:21:57 -0800 Subject: [PATCH 1/3] Fix problem with notebook apis not being used. (#15366) --- news/2 Fixes/15364.md | 1 + src/client/common/application/notebook.ts | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) create mode 100644 news/2 Fixes/15364.md diff --git a/news/2 Fixes/15364.md b/news/2 Fixes/15364.md new file mode 100644 index 000000000000..3d49c2ac9734 --- /dev/null +++ b/news/2 Fixes/15364.md @@ -0,0 +1 @@ +Allow support for using notebook APIs in the VS code stable build. diff --git a/src/client/common/application/notebook.ts b/src/client/common/application/notebook.ts index 52557d820184..bd5a873d7361 100644 --- a/src/client/common/application/notebook.ts +++ b/src/client/common/application/notebook.ts @@ -85,7 +85,7 @@ export class VSCodeNotebook implements IVSCodeNotebook { @inject(IDisposableRegistry) private readonly disposables: IDisposableRegistry, @inject(IApplicationEnvironment) readonly env: IApplicationEnvironment, ) { - if (this.useProposedApi && this.env.channel === 'insiders') { + if (this.useProposedApi) { this.addEventHandlers(); this.canUseNotebookApi = true; } From 25ee1f92f4f425dff6a40eb8f7a78b6c22eb5723 Mon Sep 17 00:00:00 2001 From: rchiodo Date: Tue, 9 Feb 2021 14:35:08 -0800 Subject: [PATCH 2/3] Update changelog --- CHANGELOG.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 290fb2d196f3..93d944df5799 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -29,6 +29,8 @@ ([#15232](https://github.com/Microsoft/vscode-python/issues/15232)) 1. Ensure target environment is activated in the terminal when running install scripts. ([#15285](https://github.com/Microsoft/vscode-python/issues/15285)) +1. Allow support for using notebook APIs in the VS code stable build. + ([#15364](https://github.com/Microsoft/vscode-python/issues/15364)) ### Code Health From 22621cb26c341a2de1fb3f91d0f837e0372c375d Mon Sep 17 00:00:00 2001 From: rchiodo Date: Tue, 9 Feb 2021 14:36:34 -0800 Subject: [PATCH 3/3] Remove news file --- news/2 Fixes/15364.md | 1 - 1 file changed, 1 deletion(-) delete mode 100644 news/2 Fixes/15364.md diff --git a/news/2 Fixes/15364.md b/news/2 Fixes/15364.md deleted file mode 100644 index 3d49c2ac9734..000000000000 --- a/news/2 Fixes/15364.md +++ /dev/null @@ -1 +0,0 @@ -Allow support for using notebook APIs in the VS code stable build.