From ac41b5ea744a55cd49795eef55eb190dd84d0a23 Mon Sep 17 00:00:00 2001 From: Derek Keeler Date: Tue, 22 Jan 2019 14:12:46 -0800 Subject: [PATCH 1/2] Slow updates to pip - v19.0 breaks our CI --- .travis.yml | 2 +- build/ci/templates/compile-and-validate.yml | 2 +- build/ci/templates/test-phase.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 15fd547ce708..8a325b4570f4 100644 --- a/.travis.yml +++ b/.travis.yml @@ -65,7 +65,7 @@ install: - travis_wait 5 npm ci - npm run clean - npx gulp prePublishNonBundle - - python -m pip install --upgrade pip + - python -m pip install --upgrade pip<19 - python -m pip install --upgrade -r ./build/test-requirements.txt - npx gulp installPythonLibs diff --git a/build/ci/templates/compile-and-validate.yml b/build/ci/templates/compile-and-validate.yml index ea00096fa6d0..20374d6ec4fb 100644 --- a/build/ci/templates/compile-and-validate.yml +++ b/build/ci/templates/compile-and-validate.yml @@ -145,7 +145,7 @@ jobs: inputs: filename: python - arguments: '-m pip install --upgrade pip' + arguments: '-m pip install --upgrade pip<19' - task: CmdLine@1 diff --git a/build/ci/templates/test-phase.yml b/build/ci/templates/test-phase.yml index 14cfc8c664df..79a3c9a0ed88 100644 --- a/build/ci/templates/test-phase.yml +++ b/build/ci/templates/test-phase.yml @@ -118,7 +118,7 @@ steps: inputs: filename: python - arguments: '-m pip install --upgrade pip' + arguments: '-m pip install --upgrade pip<19' - task: CmdLine@1 From b8b5baf2b8500475a80662a48f5e714f1485c6d3 Mon Sep 17 00:00:00 2001 From: Derek Keeler Date: Tue, 22 Jan 2019 14:26:34 -0800 Subject: [PATCH 2/2] Quotes needed --- .travis.yml | 2 +- build/ci/templates/compile-and-validate.yml | 2 +- build/ci/templates/test-phase.yml | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index 8a325b4570f4..cfc05776128f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -65,7 +65,7 @@ install: - travis_wait 5 npm ci - npm run clean - npx gulp prePublishNonBundle - - python -m pip install --upgrade pip<19 + - python -m pip install --upgrade 'pip<19' - python -m pip install --upgrade -r ./build/test-requirements.txt - npx gulp installPythonLibs diff --git a/build/ci/templates/compile-and-validate.yml b/build/ci/templates/compile-and-validate.yml index 20374d6ec4fb..27ce3b5164e2 100644 --- a/build/ci/templates/compile-and-validate.yml +++ b/build/ci/templates/compile-and-validate.yml @@ -145,7 +145,7 @@ jobs: inputs: filename: python - arguments: '-m pip install --upgrade pip<19' + arguments: '-m pip install --upgrade "pip<19"' - task: CmdLine@1 diff --git a/build/ci/templates/test-phase.yml b/build/ci/templates/test-phase.yml index 79a3c9a0ed88..85e7ea4fa7ae 100644 --- a/build/ci/templates/test-phase.yml +++ b/build/ci/templates/test-phase.yml @@ -118,7 +118,7 @@ steps: inputs: filename: python - arguments: '-m pip install --upgrade pip<19' + arguments: '-m pip install --upgrade "pip<19"' - task: CmdLine@1