From 49ef32d704b9b2790b93e40369d6be477a7cf89a Mon Sep 17 00:00:00 2001 From: Don Jayamanne Date: Tue, 26 Mar 2019 08:30:59 -0700 Subject: [PATCH] Ensure output panel does not steal focus due to ls errors --- news/2 Fixes/4868.md | 1 + src/client/activation/languageServer/analysisOptions.ts | 3 ++- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 news/2 Fixes/4868.md diff --git a/news/2 Fixes/4868.md b/news/2 Fixes/4868.md new file mode 100644 index 000000000000..1c0d62a00597 --- /dev/null +++ b/news/2 Fixes/4868.md @@ -0,0 +1 @@ +Ensure the `Python` output panel does not steal focus when there errors in the `Language Server`. diff --git a/src/client/activation/languageServer/analysisOptions.ts b/src/client/activation/languageServer/analysisOptions.ts index 551666405572..f7add0bc377d 100644 --- a/src/client/activation/languageServer/analysisOptions.ts +++ b/src/client/activation/languageServer/analysisOptions.ts @@ -6,7 +6,7 @@ import { inject, injectable, named } from 'inversify'; import * as path from 'path'; import { CancellationToken, CompletionContext, ConfigurationChangeEvent, Disposable, Event, EventEmitter, OutputChannel, Position, TextDocument } from 'vscode'; -import { LanguageClientOptions, ProvideCompletionItemsSignature } from 'vscode-languageclient'; +import { LanguageClientOptions, ProvideCompletionItemsSignature, RevealOutputChannelOn } from 'vscode-languageclient'; import { IWorkspaceService } from '../../common/application/types'; import { isTestExecution, PYTHON_LANGUAGE, STANDARD_OUTPUT_CHANNEL } from '../../common/constants'; import { traceDecorators, traceError } from '../../common/logger'; @@ -120,6 +120,7 @@ export class LanguageServerAnalysisOptions implements ILanguageServerAnalysisOpt configurationSection: PYTHON_LANGUAGE }, outputChannel: this.output, + revealOutputChannelOn: RevealOutputChannelOn.Never, initializationOptions: { interpreter: { properties