Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix problem with other kernels that use python being picked. #5628

Merged
merged 1 commit into from May 14, 2019
Merged

Fix problem with other kernels that use python being picked. #5628

merged 1 commit into from May 14, 2019

Conversation

rchiodo
Copy link

@rchiodo rchiodo commented May 14, 2019

For #5586

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • Has a news entry file (remember to thank yourself!)
  • Appropriate comments and documentation strings in the code
  • Has sufficient logging.
  • Has telemetry for enhancements.
  • Unit tests & system/integration tests are added/updated
  • Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)
  • The wiki is updated with any design decisions/details.

@rchiodo
Copy link
Author

rchiodo commented May 14, 2019

I also added support for debugging in a devcontainer.

IanMatthewHuff
IanMatthewHuff approved these changes May 14, 2019
View reviewed changes
Copy link
Member

@IanMatthewHuff IanMatthewHuff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@rchiodo rchiodo merged commit f1deef6 into master May 14, 2019
@rchiodo rchiodo deleted the rchiodo/fix_5586 branch May 14, 2019 20:15
@lock lock bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@IanMatthewHuff IanMatthewHuff IanMatthewHuff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rchiodo @IanMatthewHuff