From c4de520c28866bd0eb54f8e5539220e6868cf8be Mon Sep 17 00:00:00 2001 From: Rich Chiodo Date: Wed, 16 Oct 2019 08:57:10 -0700 Subject: [PATCH] Fix max output size to be passed down to rendering --- news/2 Fixes/8010.md | 1 + src/datascience-ui/history-react/interactiveCell.tsx | 1 + src/datascience-ui/interactive-common/cellOutput.tsx | 2 +- src/datascience-ui/native-editor/nativeCell.tsx | 1 + 4 files changed, 4 insertions(+), 1 deletion(-) create mode 100644 news/2 Fixes/8010.md diff --git a/news/2 Fixes/8010.md b/news/2 Fixes/8010.md new file mode 100644 index 000000000000..a0b0378621d2 --- /dev/null +++ b/news/2 Fixes/8010.md @@ -0,0 +1 @@ +Fix python.dataScience.maxOutputSize to be honored again. diff --git a/src/datascience-ui/history-react/interactiveCell.tsx b/src/datascience-ui/history-react/interactiveCell.tsx index 41686aaae886..63cc46ac4cb8 100644 --- a/src/datascience-ui/history-react/interactiveCell.tsx +++ b/src/datascience-ui/history-react/interactiveCell.tsx @@ -144,6 +144,7 @@ export class InteractiveCell extends React.Component { baseTheme={this.props.baseTheme} expandImage={this.props.expandImage} openLink={this.props.openLink} + maxTextSize={this.props.maxTextSize} /> diff --git a/src/datascience-ui/interactive-common/cellOutput.tsx b/src/datascience-ui/interactive-common/cellOutput.tsx index c775d2ad80cb..fc2094d49fec 100644 --- a/src/datascience-ui/interactive-common/cellOutput.tsx +++ b/src/datascience-ui/interactive-common/cellOutput.tsx @@ -254,7 +254,7 @@ export class CellOutput extends React.Component { data: concatMultilineStringOutput(data as nbformat.MultilineString), isText, isError, - renderWithScrollbars, + renderWithScrollbars: true, extraButton, doubleClick: noop }; diff --git a/src/datascience-ui/native-editor/nativeCell.tsx b/src/datascience-ui/native-editor/nativeCell.tsx index ff1ee03e549a..066877ffa7ad 100644 --- a/src/datascience-ui/native-editor/nativeCell.tsx +++ b/src/datascience-ui/native-editor/nativeCell.tsx @@ -697,6 +697,7 @@ export class NativeCell extends React.Component { baseTheme={this.props.baseTheme} expandImage={this.props.stateController.showPlot} openLink={this.props.stateController.openLink} + maxTextSize={this.props.maxTextSize} /> ); }