Skip to content

Conversation

@DonJayamanne
Copy link

No description provided.

@codecov-io
Copy link

codecov-io commented Dec 20, 2019

Codecov Report

Merging #9253 into master will decrease coverage by 0.31%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9253      +/-   ##
==========================================
- Coverage   57.57%   57.26%   -0.32%     
==========================================
  Files         557      557              
  Lines       29585    29585              
  Branches     4473     4467       -6     
==========================================
- Hits        17035    16941      -94     
- Misses      11603    11697      +94     
  Partials      947      947
Impacted Files Coverage Δ
src/client/testing/serviceRegistry.ts 49.09% <0%> (-47.28%) ⬇️
src/client/testing/codeLenses/main.ts 40% <0%> (-30%) ⬇️
src/datascience-ui/interactive-common/tokenizer.ts 35% <0%> (-30%) ⬇️
src/client/datascience/jupyter/jupyterUtils.ts 64.7% <0%> (-29.42%) ⬇️
...t/datascience/jupyter/jupyterDataRateLimitError.ts 50% <0%> (-25%) ⬇️
src/client/formatters/serviceRegistry.ts 75% <0%> (-25%) ⬇️
src/datascience-ui/native-editor/redux/store.ts 75% <0%> (-25%) ⬇️
src/datascience-ui/history-react/redux/store.ts 75% <0%> (-25%) ⬇️
src/datascience-ui/react-common/arePathsSame.ts 37.5% <0%> (-25%) ⬇️
...ience/jupyter/jupyterDebuggerRemoteNotSupported.ts 60% <0%> (-20%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb15839...030b9b6. Read the comment docs.

@DonJayamanne DonJayamanne added the no-changelog No news entry required label Dec 20, 2019
Copy link
Member

@brettcannon brettcannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My approval is simply because nothing broke. 😉

@DonJayamanne DonJayamanne merged commit 43d30fd into microsoft:master Jan 2, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Jan 9, 2020
@DonJayamanne DonJayamanne deleted the removeIpyWidgets branch April 30, 2020 17:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog No news entry required

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants