Skip to content

Commit

Permalink
Removed CodePush
Browse files Browse the repository at this point in the history
  • Loading branch information
Anna Kocheshkova committed Apr 19, 2018
1 parent 3c69650 commit 0a28354
Show file tree
Hide file tree
Showing 135 changed files with 22 additions and 32,180 deletions.
24 changes: 0 additions & 24 deletions README.md
View file
Expand Up @@ -68,30 +68,6 @@ For more details about configuring and debugging Expo applications see [Expo doc

You can add VSCode tasks to build an .apk file and generate iOS/Android bundles. See [here](doc/tasks.md) for more info.

## Using with React Native CodePush

We have added basic support for [react-native-code-push](https://github.com/Microsoft/react-native-code-push) npm package.

This is our first release of this feature and we would love to hear any feedback from you to make things better.
Please [feel free to reach us](https://github.com/Microsoft/vscode-react-native/issues) in case of any issues or questions.

CodePush is a cloud service that enables Cordova and React Native developers to deploy mobile app updates directly to their users' devices. It works by acting as a central repository that developers can publish updates to (JS, HTML, CSS and images). [How does it work?](https://github.com/Microsoft/react-native-code-push#how-does-it-work)

To use it with your current project you should have the following things to be done:
1) Your currently opened project should be `react-native` one
2) You should have added `react-native-code-push` package into your project
3) You should have an app already created in [Microsoft AppCenter](https://appcenter.ms/) and configured react-native-code-push for your project:
* [How to configure React Native CodePush](https://github.com/Microsoft/react-native-code-push#getting-started)
* [How to create an App in the AppCenter portal](https://docs.microsoft.com/en-us/appcenter/sdk/getting-started/react-native#2-create-your-app-in-the-app-center-portal-to-obtain-the-app-secret)

To start using CodePush with current extension please do the following:
1) Login to AppCenter from CodePush status bar
2) Set current app that will be used for further code-push releases
3) Configure AppVersion/IsMandatory for release (optional)
4) Click on CodePush status bar and select `Releae React` command to make new CodePush release

For more details about configuring and using React Native CodePush applications see [this link](doc/rncp.md).

## Contributing

Please see our [contributing guide](CONTRIBUTING.md) for more information
Expand Down
55 changes: 0 additions & 55 deletions doc/rncp.md
View file

This file was deleted.

15 changes: 5 additions & 10 deletions gulpfile.js
View file
Expand Up @@ -85,8 +85,7 @@ var lintSources = [
].map(function (tsFolder) { return tsFolder + "/**/*.ts"; });
lintSources = lintSources.concat([
"!src/typings/**",
"!test/resources/sampleReactNative022Project/**",
"!src/extension/appcenter/lib/**"
"!test/resources/sampleReactNative022Project/**"
]);

var libtslint = require("tslint");
Expand Down Expand Up @@ -121,7 +120,7 @@ function test() {
gulp.task("test", ["build", "tslint"], test);

gulp.task('coverage:instrument', function () {
return gulp.src(["src/**/*.js", "!test/**", "!src/extension/appcenter/lib/**"])
return gulp.src(["src/**/*.js", "!test/**"])
.pipe(istanbul({
// Use the isparta instrumenter (code coverage for ES6)
instrumenter: isparta.Instrumenter,
Expand All @@ -133,7 +132,7 @@ gulp.task('coverage:instrument', function () {

gulp.task('coverage:report', function (done) {
return gulp.src(
["src/**/*.js", "!test/**", "!src/extension/appcenter/lib/**"],
["src/**/*.js", "!test/**"],
{ read: false }
)
.pipe(istanbul.writeReports({
Expand Down Expand Up @@ -170,11 +169,9 @@ gulp.task("check-copyright", function (cb) {
"!**/*.d.ts",
"!coverage/**",
"!node_modules/**",
"!lib/**",
"!test/**/*.js",
"!SampleApplication/**",
"!test/resources/sampleReactNative022Project/**/*.js",
"!src/extension/appcenter/lib/**",
"!test/resources/sampleReactNative022Project/**/*.js"
])
.pipe(copyright());
});
Expand All @@ -187,12 +184,10 @@ gulp.task("clean", function () {
var del = require("del");
var pathsToDelete = [
"src/**/*.js",
"!src/extension/appcenter/lib/**/*.js",
"src/**/*.js.map",
"test/**/*.js",
"test/**/*.js.map",
"out/",
"!src/extension/codepush/api/codepush-sdk/**/*.js",
"!test/resources/sampleReactNative022Project/**/*.js",
".vscode-test/"
]
Expand Down Expand Up @@ -237,4 +232,4 @@ gulp.task("release", ["build"], function () {
fs.writeFileSync(path.join(__dirname, fileName), fs.readFileSync(path.join(backupFolder, fileName)));
});
});
});
});
144 changes: 10 additions & 134 deletions package.json
View file
Expand Up @@ -12,9 +12,7 @@
"description": "Code-hinting, debugging and integrated commands for React Native",
"keywords": [
"react-native",
"multi-root ready",
"app-center",
"code-push"
"multi-root ready"
],
"bugs": "https://github.com/Microsoft/vscode-react-native/issues",
"license": "SEE LICENSE IN LICENSE.txt",
Expand Down Expand Up @@ -42,17 +40,7 @@
"onCommand:reactNative.restartPackager",
"onCommand:reactNative.publishToExpHost",
"onCommand:reactNative.showDevMenu",
"onCommand:reactNative.reloadApp",
"onCommand:reactNative.appcenter.login",
"onCommand:reactNative.appcenter.logout",
"onCommand:reactNative.appcenter.whoami",
"onCommand:reactNative.appcenter.setcurrentapp",
"onCommand:reactNative.appcenter.getcurrentapp",
"onCommand:reactNative.appcenter.setcurrentdeployment",
"onCommand:reactNative.appcenter.releasereact",
"onCommand:reactNative.switchMandatoryPropForRelease",
"onCommand:reactNative.setTargetBinaryVersion",
"onCommand:reactNative.showmenu"
"onCommand:reactNative.reloadApp"
],
"main": "./src/extension/rn-extension",
"contributes": {
Expand Down Expand Up @@ -100,56 +88,6 @@
{
"command": "reactNative.reloadApp",
"title": "React Native: Reload App"
},
{
"command": "reactNative.appcenter.login",
"title": "Login",
"category": "React Native Code Push"
},
{
"command": "reactNative.appcenter.logout",
"title": "Logout",
"category": "React Native Code Push"
},
{
"command": "reactNative.appcenter.whoami",
"title": "WhoAmI",
"category": "React Native Code Push"
},
{
"command": "reactNative.appcenter.setcurrentapp",
"title": "Set Current App",
"category": "React Native Code Push"
},
{
"command": "reactNative.appcenter.getcurrentapp",
"title": "Get Current App",
"category": "React Native Code Push"
},
{
"command": "reactNative.appcenter.setcurrentdeployment",
"title": "Set Current Deployment",
"category": "React Native Code Push"
},
{
"command": "reactNative.appcenter.releasereact",
"title": "Release React",
"category": "React Native Code Push"
},
{
"command": "reactNative.appcenter.switchMandatoryPropForRelease",
"title": "Switch Code Push release mandatory property",
"category": "React Native Code Push"
},
{
"command": "reactNative.appcenter.setTargetBinaryVersion",
"title": "Set Code Push release target binary verison",
"category": "React Native Code Push"
},
{
"command": "reactNative.appcenter.showmenu",
"title": "Show Menu",
"category": "React Native Code Push"
}
],
"debuggers": [
Expand Down Expand Up @@ -536,30 +474,6 @@
],
"default": "Info",
"scope": "resource"
},
"react-native-tools.appcenter.loginendpoint": {
"description": "Endpoint to login to appcenter",
"type": "string",
"default": "https://appcenter.ms/cli-login",
"scope": "resource"
},
"react-native-tools.appcenter.api.endpoint": {
"description": "API Endpoint to appcenter",
"type": "string",
"default": "https://api.appcenter.ms",
"scope": "resource"
},
"react-native-tools.appcenter.legacycodepushservice": {
"description": "Legacy codepush service endpoint",
"type": "string",
"default": "https://codepush-management.azurewebsites.net/",
"scope": "resource"
},
"react-native-tools.appcenter.legacycodepushserviceenabled": {
"description": "Select if legacy service is used for CodePush release",
"type": "boolean",
"default": true,
"scope": "resource"
}
}
}
Expand All @@ -572,57 +486,28 @@
"postinstall": "node ./node_modules/vscode/bin/install"
},
"dependencies": {
"chalk": "^2.3.0",
"crypto": "^1.0.1",
"date-fns": "^1.29.0",
"extract-opts": "2.2.0",
"flatten-source-map": "0.0.2",
"gradle-to-js": "^1.0.1",
"jsonwebtoken": "^8.1.1",
"jszip": "^3.1.5",
"lodash": "^4.17.5",
"mkdirp": "^0.5.1",
"moment": "^2.21.0",
"ms-rest": "^2.2.5",
"node-noop": "^1.0.0",
"noice-json-rpc": "^1.0.2",
"open": "0.0.5",
"opener": "^1.4.3",
"options": "0.0.6",
"plist": "^2.1.0",
"properties": "^1.2.1",
"q": "1.4.1",
"qr-image": "^3.2.0",
"qs": "^6.4.0",
"request": "^2.83.0",
"rimraf": "^2.6.2",
"rx-lite": "^4.0.8",
"semver": "^5.5.0",
"source-map": "0.5.2",
"semver": "5.1.0",
"source-map-resolve": "^0.5.0",
"strip-json-comments": "2.0.1",
"temp": "^0.8.3",
"typechecker": "2.0.8",
"ultron": "1.0.2",
"vscode-chrome-debug-core": "^3.17.3",
"vscode-debugadapter": "^1.23.0",
"vscode-debugprotocol": "^1.23.0",
"vscode-extension-telemetry": "0.0.5",
"which": "^1.3.0",
"ws": "^3.2.0",
"xml2js": "^0.4.19",
"yazl": "^2.4.3"
"ws": "^3.2.0"
},
"devDependencies": {
"@types/lodash": "^4.14.74",
"@types/mocha": "^2.2.40",
"@types/mock-fs": "^3.6.30",
"@types/open": "^0.0.29",
"@types/opener": "^1.4.0",
"@types/node": "^6.0.65",
"@types/qr-image": "^3.2.0",
"@types/qs": "^6.5.0",
"@types/request": "^2.47.0",
"@types/rx-lite": "4.0.4",
"@types/shelljs": "^0.7.0",
"@types/source-map": "0.5.2",
"@types/source-map-support": "^0.2.28",
Expand All @@ -635,9 +520,11 @@
"gulp-preprocess": "^2.0.0",
"gulp-sourcemaps": "^1.6.0",
"gulp-tslint": "^8.1.2",
"gulp-typescript": "^3.1.5",
"gulp-util": "^3.0.7",
"isparta": "^4.0.0",
"minimist": "^1.2.0",
"mocha": "^3.2.0",
"mocha-teamcity-reporter": "^1.0.0",
"mock-fs": "^4.4.1",
"remap-istanbul": "^0.9.5",
Expand All @@ -646,30 +533,19 @@
"sinon": "^1.17.3",
"source-map-support": "^0.4.0",
"through2": "^2.0.1",
"tslint": "^5.6.0",
"typescript": "2.4.2",
"vsce": "^1.3.0",
"vscode": "^1.1.6",
"@types/chalk": "^2.2.0",
"@types/date-fns": "^2.6.0",
"@types/jsonwebtoken": "^7.2.5",
"@types/jszip": "^3.1.3",
"@types/mkdirp": "^0.5.2",
"@types/rimraf": "^2.0.2",
"@types/semver": "^5.5.0",
"@types/temp": "^0.8.31",
"@types/which": "^1.3.1",
"@types/xml2js": "^0.4.2",
"gulp-install": "^1.1.0",
"gulp-sequence": "1.0.0",
"gulp-typescript": "^3.1.5",
"jest": "^22.1.4",
"jest-cli": "^22.1.4",
"rmdir": "^1.2.0",
"testdouble": "^3.3.3",
"ts-jest": "^22.0.3",
"ts-node": "^4.1.0",
"tslint": "^5.6.0",
"tslint-microsoft-contrib": "^5.0.2"
"tslint-microsoft-contrib": "^5.0.2",
"vscode": "^1.1.6"
},
"extensionDependencies": [
"ms-vscode.node-debug2"
Expand Down
11 changes: 0 additions & 11 deletions src/common/error/internalErrorCode.ts
View file
Expand Up @@ -15,17 +15,6 @@ export enum InternalErrorCode {
FailedToStartExponentPackager = 110,
FailedToPublishToExpHost = 111,

FailedToExecAppCenterLogin = 112,
FailedToExecAppCenterLogout = 113,
FailedToExecAppCenterWhoAmI = 114,
FailedToExecAppCenterSetCurrentApp = 115,
FailedToExecAppCenterGetCurrentApp = 116,
FailedToExecAppCenterReleaseReact = 117,
FailedToExecAppCenterSetCurrentDeployment = 118,
FailedToExecAppCenterShowMenu = 119,
FailedToExecAppCenterSwitchMandatoryPropForRelease = 120,
FailedToExecAppCenterSetTargetBinaryVersionForRelease = 121,

// Device Deployer errors
IOSDeployNotFound = 201,

Expand Down

0 comments on commit 0a28354

Please sign in to comment.