Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make vscode-RN debug with TypeScript file #259

Merged
merged 1 commit into from Jul 8, 2016

Conversation

frogcjn
Copy link
Contributor

@frogcjn frogcjn commented Jul 8, 2016

No description provided.

@msftclas
Copy link

msftclas commented Jul 8, 2016

Hi @frogcjn, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
You've already signed the contribution license agreement. Thanks!

The agreement was validated by Microsoft and real humans are currently evaluating your PR.

TTYL, MSBOT;

@frogcjn frogcjn changed the title make vscode-RN can debug with TypeScript file make vscode-RN debug with TypeScript file Jul 8, 2016
@frogcjn
Copy link
Contributor Author

frogcjn commented Jul 8, 2016

@MSLaguana , here is the squashed branch

@MSLaguana
Copy link
Member

Looks good, I'll merge it in now. Thanks a lot!

@MSLaguana MSLaguana merged commit 778634f into microsoft:master Jul 8, 2016
@joekim
Copy link

joekim commented Aug 10, 2016

I'd love to started using the functionality. I've been waiting a while for a new release. Would it make sense to just grab this merge and start using it?

@MSLaguana
Copy link
Member

We hope to publish a release in the near future, but if you want to use this now then you can check out master branch and build from that and it will include these changes.

@joewood
Copy link

joewood commented Sep 4, 2016

Is this now released as part of 0.1.6?
TS Debugging still doesn't seem to work for me with this version. Is there an example project with this working? Any special settings for source maps required (e.g. inlineSourcemaps?)

@joewood
Copy link

joewood commented Sep 5, 2016

OK, with a bit of experimenting I got this to work. I had to do a couple of things:

  • I used "inlineSourceMap":true in the tsconfig.json.
  • I made sure source maps were available for the root file (previously I had a JavaScript root JS file that simply required a separate TS file)

@tomauty
Copy link

tomauty commented Oct 7, 2016

@joewood can you post your tsconfig file? I can't seem to get this to work :(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants