From edd70e3f74233a9ca2816b1d718451e766d64c08 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jo=C3=A3o=20Moreno?= <joaomoreno@users.noreply.github.com>
Date: Fri, 25 Jun 2021 09:51:25 +0200
Subject: [PATCH] update ignore tests

---
 src/test/fixtures/vscodeignore/.vscodeignore     |  6 +++++-
 src/test/fixtures/vscodeignore/foo/bar/hello.txt |  1 +
 src/test/package.test.ts                         | 11 +++++------
 3 files changed, 11 insertions(+), 7 deletions(-)
 create mode 100644 src/test/fixtures/vscodeignore/foo/bar/hello.txt

diff --git a/src/test/fixtures/vscodeignore/.vscodeignore b/src/test/fixtures/vscodeignore/.vscodeignore
index 6c1be845..bd30504d 100644
--- a/src/test/fixtures/vscodeignore/.vscodeignore
+++ b/src/test/fixtures/vscodeignore/.vscodeignore
@@ -5,4 +5,8 @@
 out/
 
 # pattern of file name
-*.log
\ No newline at end of file
+*.log
+
+# https://github.com/microsoft/vscode-vsce/issues/588
+foo
+!foo/bar/hello.txt
\ No newline at end of file
diff --git a/src/test/fixtures/vscodeignore/foo/bar/hello.txt b/src/test/fixtures/vscodeignore/foo/bar/hello.txt
new file mode 100644
index 00000000..6d20e91b
--- /dev/null
+++ b/src/test/fixtures/vscodeignore/foo/bar/hello.txt
@@ -0,0 +1 @@
+hi there
\ No newline at end of file
diff --git a/src/test/package.test.ts b/src/test/package.test.ts
index a09218e5..fe31ec76 100644
--- a/src/test/package.test.ts
+++ b/src/test/package.test.ts
@@ -150,14 +150,13 @@ describe('collect', function () {
 			});
 	});
 
-	it('should ignore content of .vscodeignore', () => {
+	it('should ignore content of .vscodeignore', async () => {
 		const cwd = fixture('vscodeignore');
+		const manifest = await readManifest(cwd);
+		const files = await collect(manifest, { cwd });
+		const names = files.map(f => f.path).sort();
 
-		return readManifest(cwd)
-			.then(manifest => collect(manifest, { cwd }))
-			.then(files => {
-				assert.equal(files.length, 3);
-			});
+		assert.deepStrictEqual(names, ['[Content_Types].xml', 'extension.vsixmanifest', 'extension/package.json']);
 	});
 
 	it('should ignore devDependencies', () => {