Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Option to use a particular .vscodeignore file #255

Closed
akshita31 opened this issue Apr 5, 2018 · 2 comments · Fixed by #294
Closed

Option to use a particular .vscodeignore file #255

akshita31 opened this issue Apr 5, 2018 · 2 comments · Fixed by #294
Assignees
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@akshita31
Copy link

Is there an option to use a particular .vscodeignore file (which may not be present directly in the current working directory or one with a different name) ?

@TheRealPiotrP
Copy link

The ability to specify .vscodeignore files to vsce would help extensions like C# increase the determinism of their builds. Extensions like ours require access to the internet at runtime to download platform-specific components [in our case this is OmniSharp as well as a .NET Debugger implementation]. It is necessary for us to build two flavors of our VSIX, one that downloads these assets on the fly and another, much larger, that includes platform-specific components. The portable package explicitly needs to ignore the platform specific components used during its own build. The platform specific flavor, conversely, needs to include these components.

We currently achieve this behavior through a combination of implicit build timing as well as a .vscodeignore file that is the lowest common denominator of these two package flavors. This is quite fragile, as you might imagine, and has recently become impossible due to capabilities we want to add to our build.

We are currently going to work around this problem by generating the .vscodeignore file during the packaging process. This solution is sub-optimal for a number of reasons:

  • we need to generate a build artifact into the project's root directory. This replaces one type of complexity with another. Our scenario requires we undertake this tradeoff, but it's far from ideal.
  • The default vsce package experience will run with an arbitrary .vscodeignore file, or none if it has yet to be generated. Given the importance of this file to the VSCE experience, it would be great if vsce could produce a warning if it sees multiple .vscodeignore files and one is not specified, perhaps an error even.

@joaomoreno
Copy link
Member

Sure, we'll take a PR for this. Shouldn't be too hard.

Maybe a --ignore-file FILE_PATH option?

@joaomoreno joaomoreno self-assigned this Apr 5, 2018
@joaomoreno joaomoreno added this to the Backlog milestone Apr 5, 2018
@joaomoreno joaomoreno added feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities labels Sep 20, 2018
@joaomoreno joaomoreno removed their assignment Sep 20, 2018
@joaomoreno joaomoreno removed this from the Backlog milestone Oct 11, 2019
@joaomoreno joaomoreno self-assigned this Nov 28, 2019
@joaomoreno joaomoreno added this to the November 2019 milestone Nov 28, 2019
@joaomoreno joaomoreno added the verification-needed Verification of issue is requested label Dec 3, 2019
@roblourens roblourens added the verified Verification succeeded label Dec 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Request for new features or functionality help wanted Issues identified as good community contribution opportunities verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants