Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

if package path is a directory, use default file name to write vsix #248

Merged
merged 1 commit into from Nov 28, 2019

Conversation

@LaChRiZ
Copy link
Contributor

LaChRiZ commented Mar 24, 2018

I improved the package path option.

If the given package output path is just a directory, it will be concatenated with the default file name ({manifest.name}-${manifest.version}.vsix) to write the VSIX file.
If it's a concrete file path, that will be used.

Otherwise, the default behaviour will be used. (current working directory with package name and version)

Hope you like it. Thanks for merging! 馃槉

@garyng

This comment has been minimized.

Copy link

garyng commented May 10, 2019

Uhmm... Will this be merged?

@LaChRiZ LaChRiZ force-pushed the LaChRiZ:feature/package-path branch from d0a03a7 to 786118d May 11, 2019
@LaChRiZ

This comment has been minimized.

Copy link
Contributor Author

LaChRiZ commented May 11, 2019

I rebased the feature branch. So it can be merged now.
I would appreciate it. It's a handy feature.

@joaomoreno joaomoreno self-assigned this May 23, 2019
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Nov 28, 2019

I find this a bit confusing. I think there should really be a check for whether such a directory exists. If so, that directory is taken as a base. Otherwise, we should take that name literally as the package name. I'll rebase and fix it.

@joaomoreno joaomoreno merged commit 786118d into microsoft:master Nov 28, 2019
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
license/cla All CLA requirements met.
@joaomoreno

This comment has been minimized.

Copy link
Member

joaomoreno commented Nov 28, 2019

Thanks! 馃巻

@joaomoreno joaomoreno added this to the November 2019 milestone Nov 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.